test(async_io): cover close cancellation and watcher re-arming#14284
Merged
rgrinberg merged 1 commit intoocaml:mainfrom Apr 22, 2026
Merged
test(async_io): cover close cancellation and watcher re-arming#14284rgrinberg merged 1 commit intoocaml:mainfrom
rgrinberg merged 1 commit intoocaml:mainfrom
Conversation
Add regression tests for [Async_io.close] cancelling a pending readiness waiter and for switching the watched mask on a file descriptor. The new cases cover: - closing an fd while a readiness task is pending - re-arming a watcher from read to write - switching the same fd from a write watch to a read watch Also add socket helper functions needed to exercise these cases on both Unix and Win32. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add regression tests for [Async_io.close] cancelling a pending readiness waiter and for switching the watched mask on a file descriptor.
The new cases cover: