Skip to content

test: add lib_root, libexec_root, share_root#14208

Merged
Alizter merged 1 commit intoocaml:mainfrom
Alizter:push-trsuvvvsxpup
Apr 17, 2026
Merged

test: add lib_root, libexec_root, share_root#14208
Alizter merged 1 commit intoocaml:mainfrom
Alizter:push-trsuvvvsxpup

Conversation

@Alizter
Copy link
Copy Markdown
Collaborator

@Alizter Alizter commented Apr 17, 2026

These fields can appear in opam files, however we haven't encountered them yet. It might be worth supporting them since we use these install sections in dune anyway.

This test simply checks how we are interpreting the fields, I will motivate adding them in a later PR. This is related to #14200.

@Alizter Alizter marked this pull request as ready for review April 17, 2026 10:49
@Alizter Alizter requested a review from rgrinberg April 17, 2026 10:50
Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter Alizter force-pushed the push-trsuvvvsxpup branch from 68d6441 to 128d359 Compare April 17, 2026 15:00
Copy link
Copy Markdown
Member

@rgrinberg rgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's worth adding support until somebody reports that this is useful

@Alizter Alizter merged commit 7cb849d into ocaml:main Apr 17, 2026
29 of 30 checks passed
@Alizter Alizter deleted the push-trsuvvvsxpup branch April 17, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants