feat(pkg): ocaml implementation of dune_patch#14177
Draft
Alizter wants to merge 1 commit intoocaml:mainfrom
Draft
feat(pkg): ocaml implementation of dune_patch#14177Alizter wants to merge 1 commit intoocaml:mainfrom
Alizter wants to merge 1 commit intoocaml:mainfrom
Conversation
Alizter
force-pushed
the
push-tlqyrstvkrzy
branch
from
6740210 to
690abdb
Compare
Alizter
commented
Apr 13, 2026
Member
|
Dear @Alizter, thanks for your work on forking/vendoring. Indeed it is a great idea to upstream patches. For this to work nicely, it is best to open a PR at the upstream repository with the patch and test (as I see you have a test that otherwise fails). |
rgrinberg
requested changes
Apr 13, 2026
Member
rgrinberg
left a comment
rgrinberg
left a comment
There was a problem hiding this comment.
Does this library support ed commands? If it doesn't, we should at least have a decent error message for that.
The split between tests and changes isn't done in a way that makes it possible to evaluate whether this changes any semantics.
Collaborator
Author
Sorry about that. This will take a little more time to do. |
Alizter
force-pushed
the
push-tlqyrstvkrzy
branch
8 times, most recently
from
0dc9f51 to
8b36d80
Compare
We vendor hannesm/patch in order to get a portable implementation of our patch action. This removes the dependency on an external patch/gpatch binary, making the patch action work reliably across all platforms. - Fixes ocaml#12232 - Fixes ocaml#7699 We also reorganise and extend the test suite for the patch action. Making sure that we test the more difficult parts of patching with good coverage. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-tlqyrstvkrzy
branch
from
8b36d80 to
6aa4bf2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We vendor hannesm/patch in order to get a portable implementation of our
patch action. This removes the dependency on an external patch/gpatch
binary, making the patch action work reliably across all platforms.
Doing so required patching the vendored library, so we should consider upstreaming this patch.
We also reorganise and extend the test suite for the patch action.
Making sure that we test the more difficult parts of patching with good
coverage.