Add comment explaining that Fpath.follow_symlink is recursive, delete follow_symlinks#14091
Conversation
Leonidas-from-XIV
left a comment
There was a problem hiding this comment.
This is very nice to know. Could you maybe also add a note in the documentation how these two functions differ, beyond just the return type? Because I share your initial confusion.
|
|
|
I think you should just get rid of |
|
Then even better to remove it, move and adapt the documentation comment. |
|
I am quite surprised to learn that the plural version is unused, it seemed like quite a smart thing to do. |
|
Are you planning to use the plural one? That would be a reason to keep it if so. |
|
What is needed to get this PR closed or merged? |
|
I just need to take a second look at it, will do now |
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
c71ba46 to
5386339
Compare
Fpath.follow_symlink is recursiveFpath.follow_symlink is recursive, delete follow_symlinks
The presence of both
follow_symlinkandfollow_symlinks(with ans) might lead people to believe that the former will only follow a singular link once. That is not the case, the whole thread is pulled.Since the plural one was completely unused, I removed it entirely.