[codex] Avoid overwriting same-second migrations#112
Merged
Conversation
e867d56 to
c181d7c
Compare
960d1c3 to
4717229
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a flake in the refreshable materialized view lifecycle test by preventing generated migration files from being overwritten when multiple
chkit generateruns happen within the same second.Root Cause
Automatic migration filenames used second-level timestamps plus the default
autoname. The lifecycle test generates several different migrations quickly, so a later generate could reuse the same filename and overwrite an already-applied migration. The next migrate then failed correctly with a checksum mismatch.Changes
_001,_002, etc.Validation
bun test packages/codegen/src/index.test.tsbun run --cwd packages/codegen typecheckbun run --cwd packages/codegen lintbun run --cwd packages/cli typecheckdoppler run --project chkit --config ci -- bun test packages/cli/src/clickhouse-live.e2e.test.ts -t "refreshable materialized view lifecycle" --timeout 240000