Skip to content

feat: create summarized RED metrics to enable faster queries#481

Open
obs-gh-mattcotter wants to merge 1 commit into
mainfrom
mc/red-metrics-summary
Open

feat: create summarized RED metrics to enable faster queries#481
obs-gh-mattcotter wants to merge 1 commit into
mainfrom
mc/red-metrics-summary

Conversation

@obs-gh-mattcotter
Copy link
Copy Markdown
Collaborator

@obs-gh-mattcotter obs-gh-mattcotter commented Apr 23, 2026 •
edited
Loading

OB-54347
After internal testing, we determined the Observe product experience for observe-agent RED metrics needed to be improved for performance. This change does the following:

  • emit a new set of RED metrics with the .summary suffix, which will only have the dimensions present in the BE service metrics
  • the RED metrics flag onlyGenerateForServiceEntrypointSpans is renamed to onlyGenerateForAPMSpans for clarity and will default to true
  • when onlyGenerateForAPMSpans is turned off, the internal (and other non-APM) span RED metrics will be renamed to have a .internal suffix
  • default to using deployment.environment.name instead of deployment.environment

orca-security-us[bot]

This comment was marked as outdated.

Sign in to view

@obs-gh-mattcotter obs-gh-mattcotter force-pushed the mc/red-metrics-summary branch 6 times, most recently from e060ddf to 7d56888 Compare May 4, 2026 14:42
@obs-gh-mattcotter obs-gh-mattcotter mentioned this pull request May 6, 2026
Open
@obs-gh-mattcotter obs-gh-mattcotter force-pushed the mc/red-metrics-summary branch from 7d56888 to c883752 Compare May 13, 2026 19:34
orca-security-us[bot]

This comment was marked as outdated.

Sign in to view

@obs-gh-mattcotter obs-gh-mattcotter force-pushed the mc/red-metrics-summary branch 3 times, most recently from 11f28f6 to e37afbc Compare May 18, 2026 00:07
orca-security-us[bot]

This comment was marked as outdated.

Sign in to view

@obs-gh-mattcotter obs-gh-mattcotter force-pushed the mc/red-metrics-summary branch from e37afbc to 26f9f7e Compare May 20, 2026 14:03
orca-security-us[bot]
orca-security-us Bot reviewed May 21, 2026
View reviewed changes
Copy link
Copy Markdown

@orca-security-us orca-security-us Bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Failed Failed Infrastructure as Code high 8   medium 60   low 155   info 26 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca
🛡️ The following IaC misconfigurations have been detected
NAME FILE
medium Service Account Token Automount Not Disabled ...rder/deployment.yaml View in code
medium Service Account Token Automount Not Disabled ...eway/deployment.yaml View in code
medium Service Account Token Automount Not Disabled ...ents/deployment.yaml View in code
medium Service Account Token Automount Not Disabled ...rics/deployment.yaml View in code
medium Service Account Token Automount Not Disabled ...arder/daemonset.yaml View in code
medium Service Account Token Automount Not Disabled ...itor/deployment.yaml View in code
medium Service Account Token Automount Not Disabled ...trics/daemonset.yaml View in code
medium Service Account Token Automount Not Disabled ...aper/deployment.yaml View in code
low Container CPU Requests Not Set ...rder/deployment.yaml View in code
low NET_RAW Capability Not Dropped ...rder/deployment.yaml View in code
low Container CPU Requests Not Set ...ents/deployment.yaml View in code
low NET_RAW Capability Not Dropped ...ents/deployment.yaml View in code
low NET_RAW Capability Not Dropped ...ents/deployment.yaml View in code
low Container CPU Requests Not Set ...rics/deployment.yaml View in code
low NET_RAW Capability Not Dropped ...rics/deployment.yaml View in code
low NET_RAW Capability Not Dropped ...rics/deployment.yaml View in code
low Container CPU Requests Not Set ...eway/deployment.yaml View in code
low Container CPU Requests Not Set ...itor/deployment.yaml View in code
low NET_RAW Capability Not Dropped ...itor/deployment.yaml View in code
low Container CPU Requests Not Set ...trics/daemonset.yaml View in code
low NET_RAW Capability Not Dropped ...trics/daemonset.yaml View in code
low Container CPU Requests Not Set ...aper/deployment.yaml View in code
low NET_RAW Capability Not Dropped ...aper/deployment.yaml View in code
low Container CPU Requests Not Set ...arder/daemonset.yaml View in code
low NET_RAW Capability Not Dropped ...arder/daemonset.yaml View in code
... ... ... ...

@obs-gh-mattcotter obs-gh-mattcotter force-pushed the mc/red-metrics-summary branch 4 times, most recently from 3ecb866 to 010ccf9 Compare May 29, 2026 13:17
@obs-gh-mattcotter obs-gh-mattcotter force-pushed the mc/red-metrics-summary branch from 010ccf9 to 9ddcaaa Compare May 29, 2026 18:34
@observeinc observeinc deleted a comment from github-actions Bot May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orca-security-us orca-security-us[bot] orca-security-us[bot] left review comments

@obs-gh-abhishekrao obs-gh-abhishekrao obs-gh-abhishekrao approved these changes

@obs-gh-virjramakrishnan obs-gh-virjramakrishnan Awaiting requested review from obs-gh-virjramakrishnan

@sfc-gh-zeningchen sfc-gh-zeningchen Awaiting requested review from sfc-gh-zeningchen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@obs-gh-mattcotter @obs-gh-abhishekrao