fix(adapters): log that HTTP is live while SSL is still provisioning - #625
Open
Devenio wants to merge 1 commit into
Open
fix(adapters): log that HTTP is live while SSL is still provisioning#625Devenio wants to merge 1 commit into
Devenio wants to merge 1 commit into
Conversation
The 443 block is only emitted once the cert exists, so operators saw a ~1 min HTTPS gap and filed it as broken SSL. Issuance is best-effort by design; the silence was the bug. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a custom-domain route is registered, the deploy log now says the site is live on HTTP while the certificate is still being issued (
HTTPS in ~1 min), instead of a silent ~1 minute HTTPS gap that operators filed as broken SSL.Motivation
A new project's route is registered with
tls: true, but nginx only emits the 443 block once the cert exists (route.tls && certsExist(domain)). The pipeline is correct — cert lands, vhost re-renders, HTTPS works — but during that ~1 minute window the site answers HTTP and nothing (or a bootstrap self-signed cert) on HTTPS. Issuance is best-effort by design (domains never fail a deploy), which is why the silence was the bug: two people reported it as broken SSL. Documented inTODO.mdunder “SSL provisioning is invisible in the deploy log.”Related issue
None
Changes
registerRoute, ifprovisionSsl && ssl, logRoute live on HTTP for ${hostname} — provisioning the certificate, HTTPS in ~1 min, then callprovisionCertas before. No log whenprovisionSslis off.registerResolvedRoutes. Issuance stays best-effort: a failed cert never fails the deploy.Verification
The new describe
registerResolvedRoutes — SSL provisioning is visible in the deploy log:registerRoute, thenprovisionCert)HTTPS in ~1 minand does not callprovisionCertwhenprovisionSslis offBefore: deploy log showed
Checking SSL for example.com...(or nothing on first compose deploys) while HTTPS was still dead. After: the log states HTTP is live and HTTPS is coming in ~1 min; existingSSL certificate active/ Action Required lines still fire when the cert lands or fails.Checklist
bun run --cwd packages/adapters lintand the route-registration tests pass locally (fullbun run testnot re-run; this PR does not touch the dashboard)