Skip to content

fix(plugin-timeline): gantt bucket labels and the Items default speak the session language (#4520) - #4532

Merged
yinlianghui merged 1 commit into
mainfrom
claude/issue-4520-timeline-vocabulary
Aug 13, 2026
Merged

fix(plugin-timeline): gantt bucket labels and the Items default speak the session language (#4520)#4532
yinlianghui merged 1 commit into
mainfrom
claude/issue-4520-timeline-vocabulary

Conversation

@yinlianghui

Copy link
Copy Markdown
Collaborator

Fixes #4520

The measured defect

objectui#4513 (PR #4523, landed as 01c918807) routed every Intl call in packages/plugin-timeline/src/renderer.tsx through useDisplayLocale(), so a zh session renders 2026年8月 on the month axis and 2026年8月11日 on item dates. Three sibling strings in the same renderer never went through Intl at all, so they stayed English on that same Chinese axis:

site rendered on a zh session now
week header Week 1 第 1 周
quarter header Q3 2026 2026年第3季度
gantt row-label default Items 条目

Verbatim red-first evidence, before the fix:

AssertionError: expected 'ItemsWeek 1BackendAPI Design' to contain '第 1 周'
AssertionError: expected 'ItemsQ3 2026BackendAPI Design' to contain '2026年第3季度'

The half-fixed state is the visible one: a Chinese date axis with English bucket labels beside it.

The channel — measured, not invented

The package already owns one: useTimelineTranslation / TIMELINE_DEFAULT_TRANSLATIONS in src/useTimelineTranslation.ts, a createSafeTranslation factory that ObjectTimeline.tsx already uses for timeline.bucket.*. No new shape was introduced and no sibling plugin's pattern needed mirroring. Three keys were added there and to all ten locale packs, nested beside the existing timeline.bucket.*:

  • timeline.scale.week — en Week {{n}}
  • timeline.scale.quarter — en Q{{quarter}} {{year}}
  • timeline.gantt.rowLabel — en Items

Existing spellings were reused where the packs had them (gantt.viewMode.quarter, 第 {{n}} 轮), each pack in its own quoting convention.

Interpolation goes through the channel's own {{hole}} parameter mechanism, never string concatenation, because word order belongs to the translation: zh puts the year first, which no Q${q} ${year} template can produce at all. A test drives a range across a year boundary specifically so a faked interpolation cannot pass.

The seam

generateTimeScaleHeaders is a pure exported function and cannot host a hook, so t is threaded in as an optional fifth parameter — the same seam #4513 opened for the resolved locale string, for the same reason. Its default is the package's own defaults table, which is exactly what the channel serves with no I18nProvider mounted, so existing three- and four-argument call sites keep producing byte-identical English (the #2942 spec-parity pins and #4513's fallback pins stay green untouched).

Authorized pin move (declared)

#4513's suite deliberately pinned Week 1 / Q3 2026 staying English in a zh session, to keep that card's scope honest, and filed the English as this issue. This card moves exactly those two expectations, in packages/plugin-timeline/src/__tests__/timeline-date-locale.test.tsx, case the locale-free header vocabularies do not go through Intl — zh:

  • expect(week.container.textContent).toContain('Week 1') becomes '第 1 周'
  • expect(quarter.container.textContent).toContain('Q3 2026') becomes '2026年第3季度'

The year expectation ('2026') is unchanged — String(getFullYear()) is a bare number with no vocabulary in it. What the case asserts is unchanged too: threading a locale did not touch these, and a locale tag is still not what spells them. Nothing else in the #4513 suite was touched.

Two channels, and why they may disagree

Worth stating because it reads like a bug and is not. Dates resolve through useDisplayLocale() (tenant regional default first — how this org writes dates); vocabulary resolves through the translate channel (the UI language — what this user reads). A tenant configured en whose user reads Chinese chrome renders Aug 2026 beside 第 1 周. That is the repo's established split — timeline.bucket.* has always behaved this way — and #4513's tenant-over-UI precedence for dates is pinned unchanged here.

Must-not-change, all pinned and green both sides

en output byte-identical everywhere; dateFormat:'iso' untouched; tenant-over-UI-language precedence for dates unchanged; the year bucket still a bare number; an author-supplied rowLabel still wins over the default; titles and descriptions unchanged.

Per the #4514 trap, the provider-mounting cases and the provider-less ones are in separate files: timeline-scale-vocabulary.test.tsx mounts an I18nProvider in every case, and timeline-scale-vocabulary-defaults.test.ts contains no React at all.

Verification

  • Red-first, predicted in writing before the run: 8 red / 12 green, matching the prediction exactly.
  • pnpm exec vitest run --maxWorkers=2 packages/plugin-timeline packages/i18n/src/__tests__52 files, 866 tests, all passing (includes the ten-pack parity tests and the moved pins).
  • type-check (both tsc passes) green for @object-ui/plugin-timeline and @object-ui/i18n.
  • check:i18n-keys, check:i18n-drift, check:control-bytes, check:phantom-deps, changeset:check — all green. The i18n gate confirms every call site passes exactly the arguments its en value has holes for.
  • eslint: 0 errors; the one warning on the new test file is the same as any fixture convention as its plugin-timeline hardcodes 'en-US' at four date sites, so timeline headers stay English on every non-English session #4513 sibling.
  • .d.ts diff measured both ways (dist and tsbuildinfo cleared between builds): purely additive — generateTimeScaleHeaders gains an optional parameter, i18n gains the three keys, zero removals. Graded minor for both packages per the entry-reachable additive precedent (fix(plugin-timeline): dates follow the active locale instead of hardcoded en-US (#4513) #4523).
  • Reverse verification via git diff + git checkout -- (never git stash); restore confirmed byte-exact by sha256 of git diff against the saved patch.

Generated by Claude Code

… the session language (#4520)

objectui#4513 routed every `Intl` call in the timeline renderer through
`useDisplayLocale()`, so a zh session renders `2026年8月` on the month axis.
Three sibling strings in the same renderer never went through `Intl` at all and
stayed English beside it: the `week` header (`Week 1`), the `quarter` header
(`Q3 2026`), and the gantt row-label default (`Items`).

These are a translation concern, not a locale-resolver one — a locale TAG
formats a date, only a TRANSLATION spells a word. All three now resolve through
the package's existing channel (`useTimelineTranslation` /
`TIMELINE_DEFAULT_TRANSLATIONS`, already used for `timeline.bucket.*`) under
three new keys carried by all ten locale packs: `timeline.scale.week`,
`timeline.scale.quarter`, `timeline.gantt.rowLabel`.

The numbers ride the channel's own `{{hole}}` parameters rather than
concatenation, because word order belongs to the translation: zh puts the year
first (`2026年第3季度`), which no `Q${q} ${year}` template can produce.

`generateTimeScaleHeaders` is a pure exported function and cannot host a hook,
so `t` is threaded in as an optional 5th parameter on the seam #4513 opened for
`locale`, defaulting to the package's own defaults table. English output is
byte-identical and existing 3-/4-argument call sites are unaffected.

#4513's suite deliberately pinned `Week 1` / `Q3 2026` staying English to keep
that card's scope honest; this card moves exactly those two expectations. The
year-only `2026` header is a bare number and stays.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017Qqyix2QcnpUC9XeYVDzx3
@vercel

vercel Bot commented Aug 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Aug 13, 2026 5:16am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 24.7 KB 350 KB
Entry file index--xgknM88.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 9.56KB 3.59KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 8.92KB 3.41KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 25.13KB 5.40KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.13KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.64KB 2.21KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 38.46KB 10.17KB
auth (createAuthenticatedFetch.js) 6.34KB 2.43KB
auth (index.js) 2.35KB 1.07KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.02KB 0.88KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 26.07KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.65KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 489.32KB 108.45KB
core (index.js) 3.37KB 1.34KB
create-plugin (index.js) 10.08KB 3.26KB
data-objectstack (index.js) 156.23KB 42.29KB
fields (index.js) 230.14KB 57.12KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 3.35KB 1.38KB
i18n (pickLocalized.js) 3.69KB 1.73KB
i18n (provider.js) 23.12KB 7.62KB
i18n (useDisplayLocale.js) 2.84KB 1.45KB
i18n (useObjectLabel.js) 27.59KB 6.63KB
i18n (useSafeTranslation.js) 7.77KB 3.13KB
layout (index.js) 38.98KB 10.85KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 4.32KB 1.64KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 8.75KB 3.06KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.67KB 1.12KB
permissions (evaluator.js) 4.41KB 1.44KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.55KB 0.71KB
plugin-ai (index.js) 15.75KB 3.80KB
plugin-calendar (index.js) 46.86KB 12.91KB
plugin-charts (index.js) 62.07KB 17.65KB
plugin-chatbot (index.js) 181.21KB 43.14KB
plugin-dashboard (index.js) 120.95KB 31.53KB
plugin-designer (index.js) 212.58KB 42.83KB
plugin-detail (index.js) 239.88KB 59.99KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 114.58KB 27.68KB
plugin-gantt (index.js) 164.14KB 39.98KB
plugin-grid (index.js) 188.40KB 50.10KB
plugin-kanban (index.js) 48.62KB 13.42KB
plugin-list (index.js) 111.13KB 27.12KB
plugin-map (index.js) 18.16KB 5.81KB
plugin-markdown (index.js) 13.72KB 4.69KB
plugin-report (index.js) 41.16KB 10.96KB
plugin-timeline (index.js) 26.68KB 7.66KB
plugin-tree (index.js) 8.50KB 2.88KB
plugin-view (index.js) 84.08KB 20.55KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.67KB 2.37KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 23.73KB 7.96KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.23KB 0.66KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 4.47KB 2.03KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.87KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-retry.js) 4.32KB 2.02KB
types (index.js) 3.05KB 1.52KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 2.59KB 1.31KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.05KB 1.93KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 3.40KB 1.71KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

Copy link
Copy Markdown
Collaborator Author

PM step-7 复核 — ACCEPT (session_017Qqyix2QcnpUC9XeYVDzx3)

  • Channel measured before used: useTimelineTranslation already existed (ObjectTimeline consumes it for timeline.bucket.*; the renderer simply never did), so no sibling mirroring, and the three keys landed in the existing nested namespace across all ten packs with existing spellings reused (gantt.viewMode.quarter's 季度-family, zh's 第 {{n}} 轮 ordinal shape). Sites re-located by content after fix(plugin-timeline): dates follow the active locale instead of hardcoded en-US (#4513) #4523's drift — exactly right.
  • Red-first predicted 8/12 in writing and matched exactly; the first verbatim failure ('ItemsWeek 1…' expected to contain '第 1 周') is the whole defect in one line. Pin moves are precisely the two authorized plugin-timeline hardcodes 'en-US' at four date sites, so timeline headers stay English on every non-English session #4513 vocabulary pins, with the case renamed so the file tells the truth about what it now asserts; the year-only pin untouched per ruling.
  • Grading correct on the first pass: both packages MINOR for entry-reachable additive growth (optional t param + TimelineTranslate + translateTimelineDefault via export *; locale packs' literal-type growth) — the fix(plugin-timeline): dates follow the active locale instead of hardcoded en-US (#4513) #4523 precedent applied without prompting.
  • The three declared decisions are all accepted: (1) the two-channel split (dates tenant-first via useDisplayLocale, vocabulary via UI language) follows from the ruling and IS the split timeline.bucket.* has always had — implemented, pinned, and stated in the changeset rather than escalated; (2) the ~3-line fallbackT mirror instead of widening into packages/i18n internals is the right surface containment, and the mirror is guarded by the defaults-table==en-pack test at both ends; (3) the auto-backgrounded typecheck pulled back to a real foreground exit 0, no watcher left armed.
  • Designer defaultValue 'Items' and the preview fixture left alone — authoring metadata, not render output. Correct scope instinct.
  • CI 20/20 green on per-job conclusions (Lint hosts the family gates; Type Check's call-site-keys and en-drift steps individually verified success).

Auto-merge armed (squash).


Generated by Claude Code


Generated by Claude Code

@yinlianghui
yinlianghui marked this pull request as ready for review August 13, 2026 05:30
@yinlianghui
yinlianghui added this pull request to the merge queue Aug 13, 2026
Merged via the queue into main with commit 0082db8 Aug 13, 2026
21 checks passed
@yinlianghui
yinlianghui deleted the claude/issue-4520-timeline-vocabulary branch August 13, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plugin-timeline gantt axis and row-label default are hardcoded English strings, so a zh session reads "Week 1" / "Q3 2026" / "Items"

2 participants