fix(fields): 记录选择器筛选面板保留 select 选项作者声明的类型 (#3422) by yinlianghui · Pull Request #3428 · objectstack-ai/objectui

yinlianghui · 2026-08-06T03:22:51Z

问题

Radix Select 只讲字符串:选项渲染成 String(opt.value),onValueChange 回传的也是那个字符串。筛选面板把它原样存进 filterValues,而 filterValuesToRecord 的 select 分支又原样透传 —— 于是选项值不是字符串时,下发的 $filter 与库里存的值类型不符,选了一个明明有记录的选项,列表却空了。

受影响的是 lookup_filters 自动派生这条路径:in/notIn 的数组值直接成为选项值,类型完全由作者写的元数据决定(LookupFilterDef.value 声明为 unknown),所以派生出的每一个非字符串选项都筛不出记录。

复现:lookup_filters: [{ field: 'level', operator: 'in', value: [1, 2, 3] }] → 打开记录选择器 → 选 1 → 下发 $filter: { level: "1" },而记录里 level 是数字 1。

修法:在控件边界回映射,不在下游猜类型

在 handleFilterChange 处按 col.options 把控件的字符串反查回作者写的原值 —— 控件讲字符串,payload 保留作者声明的类型。复用表单侧 #3090 已经确立的 matchOptionValue / toControlValue 语义(packages/components/src/renderers/form/option-value.ts,当时解决的是标准表单 select 上一模一样的类型漂移)。

没有在 filterValuesToRecord 里做 coerce:那样就得去猜 "1" 到底是 1 还是 "1",而选项列表本来就精确地回答了这个问题 —— 把区分权交给消费端猜,正是 AGENTS.md #0.1 说的"宽松兜底把错误约定固化成第二套事实契约"。

关于复制而非复用:packages/fields 确实依赖 @object-ui/components,但这两个函数是该包的模块私有实现(公开 barrel 未导出,包也没有发布深层子路径)。为共享这四行去拓宽另一个包的公共 API 不划算,因此在 fields 内保留一份副本,并在注释里注明 #3090 这个先例。

边界情况(已在代码注释与测试中写明)

String() 撞车(1 与 '1',或两个都打印成 [object Object] 的对象值):取第一个匹配项。这种选项列表本来就渲染不出来(Radix 会拿到两个同 value 的 SelectItem,React 拿到两个同 key 的子节点),这条 tie-break 是为了让结果确定,不是为了让有歧义的列表"能用"。
空字符串:空串在这里是"该字段无筛选"的哨兵(也是 select 控件"未选中"的值),所以作者写成 '' 的选项值无法表达成一个生效的筛选。这一点在 [fields] 记录选择器筛选面板:select 筛选项一律按字符串下发,lookup_filters 派生的数字/布尔选项筛不出记录 #3422 之前就是如此,本次不变 —— 回映射恢复的是选项的类型,不重新定义什么算"空选择"。
schema 派生的选项:按 spec 本来就是字符串(SelectOptionSchema.value 是 string),原样往返,[fields] lookup 记录选择器筛选面板:select 类型筛选项不带 options,下拉为空 #3336 那条新路径不受影响。
number / boolean 分支:原本就已显式 Number(raw) / Boolean(checked),不动。issue 指出的"三个分支行为不一致"是靠把 select 抬到它们的标准来消除的,不是反过来。

测试

扩展 #3421 建立的 RecordPickerDialog.filterOptions.test.tsx(拿到正确的可选项、与选中后下发正确的值,是同一个控件的两半,并排钉住):

2 个复现用例(修复前红 / 修复后绿):数字选项下发 1、布尔选项下发 false,断言用 toBe 加显式 typeof —— "1" == 1 松散断言在坏版本上会误绿。
3 个 no-op pin(修复前后都绿):schema 派生字符串选项原样往返;number 与 boolean 输入维持原有转换。
1 个撞车 tie-break 用例。

反向验证(先定方向再跑):只回退 RecordPickerDialog.tsx、保留测试,预测 12 项中恰好 3 项转红 —— 两个复现用例加同样走回映射的撞车用例。实测完全吻合:

Tests  3 failed | 9 passed (12)
  × sends the authored NUMBER …  → expected '1' to be 1
  × sends the authored BOOLEAN … → expected 'false' to be false
  × resolves a String() collision … → expected '1' to be 1

消费半径(RecordPickerFilterColumn 的下游)一并跑过:

pnpm exec vitest run packages/fields → 60 files / 929 tests passed
AccessExplainPanel + AssignedUsersSection + packages/plugin-detail(含 RelatedList) → 52 files / 453 tests passed
pnpm --filter @object-ui/fields type-check → 干净(注意全新 worktree 里必须先 pnpm --filter '@object-ui/fields^...' build,否则依赖缺 d.ts,报错看起来像本次改动弄坏了 import)
eslint 两个改动文件 → 0 error(54 条既有 warning 均不在新增行上)

Generated by Claude Code

…n's authored type (#3422) Radix Select speaks strings: the filter panel rendered each option as `String(opt.value)` and stored the string `onValueChange` handed back, so a `select` filter whose option values are numbers or booleans queried `{ level: "1" }` against records storing `level: 1` — an option that plainly has records returned an empty list. The `lookup_filters` auto-derivation is where this bites: its `in`/`notIn` options carry whatever the author wrote (`LookupFilterDef.value` is `unknown`), so every non-string option was unfilterable. Map the control's string back through `col.options` at the CONTROL boundary (`matchOptionValue` / `toControlValue`, replicating the #3090 semantics from `packages/components/src/renderers/form/option-value.ts`) rather than coercing in `filterValuesToRecord`, which would have to guess whether `"1"` meant `1` or `"1"`. Schema-derived options are strings by spec and round-trip unchanged; the `number` / `boolean` inputs already converted explicitly and are untouched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GTRjn8xBqp75dk7kFupVRt

vercel · 2026-08-06T03:22:57Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Aug 6, 2026 3:22am

github-actions · 2026-08-06T03:25:18Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	28.1 KB	350 KB
Entry file	`index-Ck4SljY0.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.47KB	3.09KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	22.10KB	4.37KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.13KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.64KB	2.21KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	35.76KB	9.11KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.91KB	0.87KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	478.80KB	105.18KB
core (index.js)	2.47KB	0.91KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	136.23KB	34.75KB
fields (index.js)	229.49KB	56.37KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.65KB	1.06KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	9.48KB	3.27KB
i18n (useObjectLabel.js)	26.14KB	6.07KB
i18n (useSafeTranslation.js)	3.26KB	1.44KB
layout (index.js)	38.53KB	10.71KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.05KB	1.53KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.75KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	44.98KB	12.37KB
plugin-charts (index.js)	61.04KB	17.31KB
plugin-chatbot (index.js)	180.09KB	42.72KB
plugin-dashboard (index.js)	112.03KB	28.88KB
plugin-designer (index.js)	210.51KB	42.51KB
plugin-detail (index.js)	232.48KB	57.34KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	111.54KB	26.97KB
plugin-gantt (index.js)	162.55KB	39.57KB
plugin-grid (index.js)	185.08KB	49.04KB
plugin-kanban (index.js)	47.89KB	13.18KB
plugin-list (index.js)	105.02KB	25.36KB
plugin-map (index.js)	16.81KB	5.24KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	40.58KB	10.58KB
plugin-timeline (index.js)	25.76KB	7.33KB
plugin-tree (index.js)	8.34KB	2.82KB
plugin-view (index.js)	83.67KB	20.43KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	19.28KB	6.38KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.02KB	0.55KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	4.47KB	2.03KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	2.46KB	1.21KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actions Bot added the tests label Aug 6, 2026

yinlianghui mentioned this pull request Aug 6, 2026

[process] git worktree 共享 refs/stash:并行 agent 之间 stash push/pop 会互相顶掉在途改动 #3430

Closed

yinlianghui mentioned this pull request Aug 6, 2026

[fields] 记录选择器筛选面板:select 筛选项一律按字符串下发,lookup_filters 派生的数字/布尔选项筛不出记录 #3422

Closed

yinlianghui marked this pull request as ready for review August 6, 2026 03:29

yinlianghui added this pull request to the merge queue Aug 6, 2026

Merged via the queue into main with commit 34d9169 Aug 6, 2026
17 checks passed

yinlianghui deleted the claude/issue-3422-picker-filter-value-map branch August 6, 2026 03:29

Navigation Menu

Uh oh!

fix(fields): 记录选择器筛选面板保留 select 选项作者声明的类型 (#3422) - #3428

fix(fields): 记录选择器筛选面板保留 select 选项作者声明的类型 (#3422)#3428
yinlianghui merged 1 commit into
mainfrom
claude/issue-3422-picker-filter-value-map

yinlianghui commented Aug 6, 2026

Uh oh!

vercel Bot commented Aug 6, 2026

Uh oh!

github-actions Bot commented Aug 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

yinlianghui commented Aug 6, 2026

问题

修法:在控件边界回映射,不在下游猜类型

边界情况(已在代码注释与测试中写明)

测试

Uh oh!

vercel Bot commented Aug 6, 2026

Uh oh!

github-actions Bot commented Aug 6, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants