Skip to content

fix(components,app-shell,core): interpolate {field} tokens in record_header api action targets #3395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baozhoutao merged 3 commits into from
Aug 5, 2026
Merged

fix(components,app-shell,core): interpolate {field} tokens in record_header api action targets #3395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a970d67
fix(components,app-shell,core): interpolate {field} tokens in record_…
claude Aug 5, 2026
1da794b
chore(console): dev-only record-header api-action preview harness (#3…
claude Aug 5, 2026
3154898
revert(core): keep _rowRecord in executeAPI's fallback body serializa…
claude Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions apps/console/record-header-preview.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<!doctype html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Record Header Actions Preview</title>
<script>
window.process = window.process || { env: { NODE_ENV: 'development' }, version: '', platform: 'browser' };
</script>
</head>
<body>
<div id="root"></div>
<script type="module" src="/src/record-header-preview.tsx"></script>
</body>
</html>
93 changes: 93 additions & 0 deletions apps/console/src/dev/DevRecordHeaderActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
/**
* Dev-only harness for record-header `type:'api'` actions (objectui#3391).
*
* Reproduces the issue's exact declaration: an object action on
* `locations:['record_header']` whose target is
* `/api/v1/data/os_tianshun_ehr_production_plan/{id}`, with a required
* field-backed param, `bodyExtra` and a confirm dialog. Before the fix the
* header executor never stashed the record under `params._rowRecord`, so the
* PATCH went out with the literal `{id}` (`%7Bid%7D` on the wire → 400).
*
* After the fix, clicking 复制 → confirming → filling the param must produce
* PATCH /api/v1/data/os_tianshun_ehr_production_plan/plan-42
* with `{ copy_ovr_start: …, copy_now: true }` in the body — observable in
* DevTools' Network panel (the request 404s/ECONNREFUSEDs without a backend;
* only the URL + body matter here). Not part of the product nav.
*/
import React from 'react';
import { MemoryRouter } from 'react-router-dom';
import { MetadataCtx, SchemaRendererProvider } from '@object-ui/react';
import { RecordDetailView } from '@object-ui/app-shell';

const OBJECT_NAME = 'os_tianshun_ehr_production_plan';
const RECORD_ID = 'plan-42';

const RECORD = {
id: RECORD_ID,
name: 'August production plan',
copy_ovr_start: '2026-08-01',
};

const OBJECT_DEF = {
name: OBJECT_NAME,
label: 'Production Plan',
fields: {
id: { type: 'text', label: 'Id' },
name: { type: 'text', label: 'Name' },
copy_ovr_start: { type: 'date', label: 'Copy Start' },
},
actions: [
{
name: 'copy_plan_row',
label: '复制',
locations: ['record_header'],
type: 'api',
method: 'PATCH',
target: `/api/v1/data/${OBJECT_NAME}/{id}`,
params: [{ field: 'copy_ovr_start', required: true }],
bodyExtra: { copy_now: true },
confirmText: '确认复制该生产计划?',
},
],
};

const dataSource: any = {
find: async () => ({ data: [] }),
findOne: async () => RECORD,
create: async () => ({}),
update: async () => ({}),
delete: async () => ({}),
};

const METADATA: any = {
objects: [OBJECT_DEF],
pages: [],
loading: false,
error: null,
refresh: async () => {},
invalidate: () => {},
ensureType: async () => [],
getItem: async () => null,
getItemsByType: () => [],
};

export const DevRecordHeaderActions: React.FC = () => (
<MemoryRouter initialEntries={[`/app/demo/${OBJECT_NAME}/${RECORD_ID}`]}>
<MetadataCtx.Provider value={METADATA}>
<SchemaRendererProvider dataSource={dataSource}>
<div className="h-screen" data-testid="record-header-harness">
<RecordDetailView
dataSource={dataSource}
objects={[OBJECT_DEF] as any}
onEdit={() => {}}
objectNameOverride={OBJECT_NAME}
recordIdOverride={RECORD_ID}
embedded
/>
</div>
</SchemaRendererProvider>
</MetadataCtx.Provider>
</MemoryRouter>
);

export default DevRecordHeaderActions;
34 changes: 34 additions & 0 deletions apps/console/src/record-header-preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
/**
* DEV-ONLY record-header api-action preview (objectui#3391).
*
* Mounts the REAL RecordDetailView with a stub dataSource and no backend so
* the `record_header` `type:'api'` `{field}`-interpolation fix can be
* browser-verified: clicking the header action must PATCH
* `/api/v1/data/os_tianshun_ehr_production_plan/plan-42` — not the literal
* `{id}` (`%7Bid%7D`) the bug sent.
*
* Served as a standalone Vite entry: open /record-header-preview.html.
* Excluded from the production build (no route references it).
*/
import React from 'react';
import ReactDOM from 'react-dom/client';
import './index.css';
import { I18nProvider } from '@object-ui/i18n';

// Register the renderers the synthesized record page resolves through
// (side-effect imports — same set the preview gallery uses).
import '@object-ui/plugin-grid';
import '@object-ui/plugin-form';
import '@object-ui/plugin-view';
import '@object-ui/plugin-list';
import '@object-ui/plugin-detail';

import { DevRecordHeaderActions } from './dev/DevRecordHeaderActions';

ReactDOM.createRoot(document.getElementById('root')!).render(
<React.StrictMode>
<I18nProvider>
<DevRecordHeaderActions />
</I18nProvider>
</React.StrictMode>,
);
Loading
Loading