fix(components): #3344 Combobox trigger 显式声明 type="button"，绝不提交外层表单 by xuyushun441-sys · Pull Request #3349 · objectstack-ai/objectui

xuyushun441-sys · 2026-08-04T05:52:11Z

修复内容

按 PM 裁决（#3344 认领评论）：给 packages/components/src/custom/combobox.tsx 的 trigger Button 加一行 type="button"，且放在 #3318 引入的 pass-through spread（{...triggerProps}）之前 —— 消费方显式传 type（如 type="submit"）时覆盖仍然生效。附带回归测试钉住两个方向的契约。

⚠️ 实测发现：bug 在当前 main 上不能复现（请 PM/维护者知悉）

写好回归测试后先对未修复的源码跑（破坏验证的红腿），3 个用例全绿 —— 追查发现当前安装的 @radix-ui/react-popover@1.1.23 的 PopoverTrigger 本身就渲染 type: "button"（在其 props spread 之前），经 asChild 的 Slot 合并落到我们的 Button 上。issue 的前提「Radix PopoverTrigger 不设 type」对该版本不成立：

缺省场景:trigger 在 DOM 上已有 type="button"，form 内点击不会提交（实测断言通过）；
覆盖场景:消费方经 pass-through 传 type="submit" 时，子元素 prop 压过 Slot prop，覆盖本来就生效。

因此本 PR 的实际性质是防御性加固 + 契约钉住：form 安全此前只由上游实现细节保证（Radix 换版本/重构掉 asChild 即失守），现在升格为本地显式声明、有回归测试把守的契约 —— 与 LookupField / MultiSelectField / RatingField 的显式写法对齐。是否要把 #3344 重新归类（bug → 加固），请 PM 定夺。

验证表

步骤	命令	结果
新回归测试 + 既有 combobox 测试	`pnpm exec vitest run packages/components/src/__tests__/combobox-trigger-type.test.tsx packages/components/src/__tests__/combobox-long-label.test.tsx --maxWorkers=2`	✅ 2 files / 7 tests passed
类型检查	`pnpm exec turbo run type-check --filter=@object-ui/components`	✅ 8 tasks successful
全量 components 包测试	见 PR 后续评论/CI	push-first,交由 CI 把关

破坏验证实录

Leg A（裁决原样：仅去掉新增行 = 回到 main 现状）→ 测试仍绿。这不是测试没牙，而正是「不能复现」的证据:Radix 1.1.23 兜底提供了 type="button"。
**Leg B（teeth check：spread 后强制 type={undefined}，模拟上游无兜底且本地无声明）**→ 2 red（缺省用例 toHaveAttribute('type', 'button') 失败；覆盖用例 type="submit" 属性断言失败）→ 还原 → 绿。证明回归测试确实把守该契约。
行为断言非空转:覆盖用例在修复前即验证 happy-dom 点击 submit 型按钮真的触发 form submit（onSubmit 被调用 1 次），故缺省用例的 not.toHaveBeenCalled() 是有效行为断言，不是恒真。

Changeset

@object-ui/components patch（fixed group,未声明 major）。未触碰 content/docs/releases/。

🤖 Generated with Claude Code

https://claude.ai/code/session_01NVPjPzmmAJ2Ngtvgg5MSRa

Generated by Claude Code

…r submits an enclosing form Inside a <form> a bare <button> defaults to type="submit". The Combobox trigger relied on Radix PopoverTrigger's Slot-supplied type="button" for form safety — an upstream implementation detail, now declared locally as a regression-tested contract. The default sits before the #3318 pass-through spread so an explicit consumer `type` still overrides. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NVPjPzmmAJ2Ngtvgg5MSRa

vercel · 2026-08-04T05:52:16Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Aug 4, 2026 5:52am

xuyushun441-sys · 2026-08-04T05:54:12Z

全量 components 包测试补录（push 后按 push-first 纪律补跑）：

pnpm exec vitest run packages/components --maxWorkers=2
 Test Files  70 passed (70)
      Tests  533 passed (533)
   Duration  102.38s

✅ 全绿，无回归。

Generated by Claude Code

github-actions · 2026-08-04T05:55:28Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	28.1 KB	350 KB
Entry file	`index-BHeCqx_b.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.47KB	3.09KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	22.10KB	4.37KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.13KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.64KB	2.21KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	35.76KB	9.11KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.91KB	0.87KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	476.70KB	104.68KB
core (index.js)	2.25KB	0.80KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	136.23KB	34.75KB
fields (index.js)	226.52KB	55.50KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	26.14KB	6.07KB
i18n (useSafeTranslation.js)	3.26KB	1.44KB
layout (index.js)	38.53KB	10.71KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.05KB	1.53KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.75KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	44.98KB	12.37KB
plugin-charts (index.js)	60.54KB	17.13KB
plugin-chatbot (index.js)	180.09KB	42.72KB
plugin-dashboard (index.js)	112.01KB	28.86KB
plugin-designer (index.js)	210.51KB	42.51KB
plugin-detail (index.js)	230.61KB	56.81KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	111.54KB	26.97KB
plugin-gantt (index.js)	162.25KB	39.55KB
plugin-grid (index.js)	185.08KB	49.04KB
plugin-kanban (index.js)	47.89KB	13.18KB
plugin-list (index.js)	104.94KB	25.32KB
plugin-map (index.js)	16.81KB	5.24KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	40.55KB	10.59KB
plugin-timeline (index.js)	25.76KB	7.33KB
plugin-tree (index.js)	8.34KB	2.82KB
plugin-view (index.js)	83.67KB	20.43KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	19.28KB	6.38KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.02KB	0.55KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	4.47KB	2.03KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	2.46KB	1.21KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actions Bot added package: components tests labels Aug 4, 2026

xuyushun441-sys marked this pull request as ready for review August 4, 2026 06:36

xuyushun441-sys added this pull request to the merge queue Aug 4, 2026

xuyushun441-sys mentioned this pull request Aug 4, 2026

Combobox trigger 按钮缺省 type —— 在表单内点击会以 submit 语义提交表单 #3344

Closed

Merged via the queue into main with commit 34595eb Aug 4, 2026
16 checks passed

xuyushun441-sys deleted the claude/issue-3344-combobox-button-type branch August 4, 2026 06:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(components): #3344 Combobox trigger 显式声明 type="button"，绝不提交外层表单 - #3349

fix(components): #3344 Combobox trigger 显式声明 type="button"，绝不提交外层表单#3349
xuyushun441-sys merged 1 commit into
mainfrom
claude/issue-3344-combobox-button-type

xuyushun441-sys commented Aug 4, 2026

Uh oh!

vercel Bot commented Aug 4, 2026

Uh oh!

xuyushun441-sys commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

xuyushun441-sys commented Aug 4, 2026

修复内容

⚠️ 实测发现：bug 在当前 main 上不能复现（请 PM/维护者知悉）

验证表

破坏验证实录

Changeset

Uh oh!

vercel Bot commented Aug 4, 2026

Uh oh!

xuyushun441-sys commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants