fix(app-shell): RecordDetailView modal 分派报告不可解析 target，删除死路 server 回退 (#3320) by xuyushun441-sys · Pull Request #3326 · objectstack-ai/objectui

xuyushun441-sys · 2026-08-04T00:29:40Z

变更说明

按 PM 裁决采用方案 a（最小修法）：在 RecordDetailView.modalActionHandler 镜像 objectstack#3959 在共享 console runtime 中的行为与错误文案。基于 #3324（#2904 dispatcher 收敛）之后的新形状。

删除死路回退：type:'modal' 的 target 既解析不到 page 也解析不到 object 时，原实现回退 serverActionHandler(action) POST 到 /actions/...。该路径永远不可能成功——framework 的 headlessActionTypeError 对 REST 上的 type:'modal' 一律 400——只会把一个 authoring 错误变成一次令人困惑的往返。现在与共享 runtime 一样返回描述性错误（指名 action、失效的 target、以及出路：type:'script' + params），错误文案与 useConsoleActionRuntime.modalActionHandler 逐字一致，两个 surface 不再漂移。
docblock 修正：原注释声称 "same rule as the shared console runtime"（自 objectstack#3959 起已不为真），重写为镜像共享 runtime 的注释并记录本次收敛（objectstack#3959 / objectui#3320）。serverActionHandler 本身保留（仍是 script handler）。
新增测试 RecordDetailView.modalDispatch.test.tsx：useConsoleActionRuntime.test.tsx 中 "reports an unresolvable target instead of POSTing to /actions" 的 RecordDetailView 侧对应测试。测试捕获视图真实传给自己 ActionProvider 的 handlers（pass-through 包装、保留真 Provider，按唯一携带 approval 的那组选取），断言：不可解析 target → 不调 modalHandler、不调 server dispatch、不发 fetch、返回 success: false 且文案含 action 名与 type:'script' with params；可解析 target → 客户端打开、绝不 POST。
changeset：@object-ui/app-shell patch（fixed group，非 major）。

方案 b（把 modal 分派上提进共享包装）未采用：需要新增导出面且净改动超过 30 行预裁上限，且会在刚合并的 #2904 表面上引入二次扰动。

未触碰 popup/SSO 文案（#3321 地盘）与 content/docs/releases/。

验证

项	命令	结果
新测试	`pnpm exec vitest run packages/app-shell/src/views/RecordDetailView.modalDispatch.test.tsx`	1 file / 2 passed
邻域套件（runtime + RecordDetailView 全部测试文件，共 7 个）	`pnpm exec vitest run …`	7 files / 90 passed
app-shell 全量	`pnpm exec vitest run packages/app-shell --maxWorkers=2`	268 files / 2317 passed, 1 skipped
类型检查	`pnpm --filter @object-ui/app-shell type-check`	通过（先构建依赖包）

破坏验证实录

把死路回退加回（return serverActionHandler(action)）后运行新测试：

× reports an unresolvable target instead of POSTing to /actions
AssertionError: expected "vi.fn()" to not be called at all, but actually been called 1 times
    251|     expect(serverActionSpy).not.toHaveBeenCalled();
Tests  1 failed | 1 passed (2)

还原后 2 passed。红点恰好落在「server dispatch 被调用」的断言上，证明该测试锁住的正是本 bug。

🤖 Generated with Claude Code

https://claude.ai/code/session_01NVPjPzmmAJ2Ngtvgg5MSRa

Generated by Claude Code

…targets instead of POSTing to /actions (#3320) Mirror objectstack#3959 on the record page: type:'modal' is CLIENT-SIDE ONLY. The pre-#3959 fallthrough to serverActionHandler could never succeed — the framework rejects type:'modal' over REST with a 400 (headlessActionTypeError) — so an unresolvable target is now reported as the authoring error it is, with the same copy as the shared console runtime. Docblock rewritten so its parity claim is true again. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NVPjPzmmAJ2Ngtvgg5MSRa

vercel · 2026-08-04T00:29:45Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Aug 4, 2026 12:29am

github-actions · 2026-08-04T00:32:16Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	28.1 KB	350 KB
Entry file	`index-CN_W5C7b.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.47KB	3.09KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	22.10KB	4.37KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.13KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.64KB	2.21KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	35.76KB	9.11KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.91KB	0.87KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	476.66KB	104.69KB
core (index.js)	2.25KB	0.80KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	136.23KB	34.75KB
fields (index.js)	224.99KB	55.14KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	26.14KB	6.07KB
i18n (useSafeTranslation.js)	3.26KB	1.44KB
layout (index.js)	38.53KB	10.71KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.05KB	1.53KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.75KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	44.98KB	12.37KB
plugin-charts (index.js)	60.54KB	17.13KB
plugin-chatbot (index.js)	180.09KB	42.72KB
plugin-dashboard (index.js)	112.01KB	28.86KB
plugin-designer (index.js)	210.51KB	42.51KB
plugin-detail (index.js)	230.56KB	56.80KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	111.54KB	26.97KB
plugin-gantt (index.js)	162.25KB	39.55KB
plugin-grid (index.js)	185.08KB	49.04KB
plugin-kanban (index.js)	47.89KB	13.18KB
plugin-list (index.js)	104.94KB	25.32KB
plugin-map (index.js)	16.81KB	5.24KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	40.55KB	10.59KB
plugin-timeline (index.js)	25.76KB	7.33KB
plugin-tree (index.js)	8.34KB	2.82KB
plugin-view (index.js)	83.67KB	20.43KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	19.28KB	6.38KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.02KB	0.55KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	4.47KB	2.03KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	2.46KB	1.21KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actions Bot added the tests label Aug 4, 2026

xuyushun441-sys marked this pull request as ready for review August 4, 2026 00:30

xuyushun441-sys added this pull request to the merge queue Aug 4, 2026

Merged via the queue into main with commit 94755bb Aug 4, 2026
14 of 16 checks passed

xuyushun441-sys deleted the claude/issue-3320-modal-dead-fallthrough branch August 4, 2026 00:30

xuyushun441-sys mentioned this pull request Aug 4, 2026

Popup-blocked toast and SSO spinner tab ship bilingual Chinese/English copy, violating the English-only commandment #3321

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(app-shell): RecordDetailView modal 分派报告不可解析 target，删除死路 server 回退 (#3320) - #3326

fix(app-shell): RecordDetailView modal 分派报告不可解析 target，删除死路 server 回退 (#3320)#3326
xuyushun441-sys merged 1 commit into
mainfrom
claude/issue-3320-modal-dead-fallthrough

xuyushun441-sys commented Aug 4, 2026

Uh oh!

vercel Bot commented Aug 4, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

xuyushun441-sys commented Aug 4, 2026

变更说明

验证

破坏验证实录

Uh oh!

vercel Bot commented Aug 4, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 4, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants