docs(skills): an unevaluable hook condition aborts the write (#4775) - #4883
Merged
Conversation
skills/objectstack-data/references/data-hooks.md had been updated for #4770 and #4784 but still closed with the pre-17 failure mode — an undeclared key leaves the condition "logged at WARN and treated as false". #4775 replaced that: an unevaluable condition now aborts the operation. This is the AI-authoring reference for hooks, so the stale sentence pointed the wrong way on the axis that matters — it told an author a typo is a soft failure, and it downgraded the two bullets above it (previous is unbound on inserts and multi:true writes; has() is not a null guard) from "this breaks your write" to "this quietly disables your hook". Swept the rest of skills/ and .claude/skills/ against the same rc.2 window; nothing else was stale. Docs-only; releases nothing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AaegKY1Y7GqTb8CKMm5GLC
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third pass of the rc.2 catch-up, after #4877 (release page) and #4881 (docs sweep run 5): the same window applied to
skills/and.claude/skills/.Skills matter more than prose here — they are what an AI author reads before emitting metadata, and #4001 closed the whole authorable surface in this window, so a stale skill now produces metadata that hard-fails at parse.
The sweep came back almost clean
Checked all 10 published skills and the 3 internal ones against the window's retirements and behaviour changes. Already correct, updated by the PRs that changed them:
objectstack-automationdocumentsscript的 config 契约要接入 #4277 的执行期 parse,先得有判别式(actionType)形态 #4343'sscript-node retirements (actionType: 'email' | 'slack'as logger-backed stubs, inlineconfig.scriptnever executed).objectstack-querycarries the [P2] data:QueryASTdeclares 12 members no executor runs — the liveness ledger governs metadata types, not the request surface #4286 prescriptions forcursor,joinsandwindowFunctions.objectstack-formuladocuments Script validation rules are silently skipped when their predicate fails to evaluate — fail-open is the wrong direction for a validation #4649 fail-closed predicates andhas(x)reads as a null guard and is not one — a publish-time lint should reject un-guarded nullable comparisons in CEL predicates #4763's build/publish rejection ofhas()as a null guard, with thenull < nullworked example.objectstack-data/references/data-hooks.mdwas updated for bug(objectql): hook 条件对着「只含本次更新字段」的残缺 record 求值,取不到的字段被吞成 false —— 审计 hook 静默不触发 #4770 (the condition reads the record, not the payload) and bug(objectql/docs): hookcondition的 CEL 作用域只绑定record—— 文档教的previous.x/ctx.record根本不存在,过渡型条件写不出来 #4784 (previousis bound), including the transition idiom.The
has(vars.picked)inobjectstack-automationis over a flow variable, not a declared record field — that is the "was this written at all" use #4763 explicitly leaves untouched. Not a finding.One finding
skills/objectstack-data/references/data-hooks.mdhad been updated for #4770 and #4784 but never for #4775, and closed theconditionsection with:That is exactly the behaviour #4775 replaced. An unevaluable condition now aborts the operation.
Wrong in the dangerous direction for an AI-authoring reference: it tells an author a typo is a soft failure. It also silently downgraded the two bullets immediately above it —
previousis unbound on inserts and onmulti: truewrites, andhas()is not a null guard — from "this breaks your write" to "this quietly disables your hook". Both are now write-failing mistakes, which is what makes those bullets load-bearing rather than stylistic.Replaced with a callout carrying the #4775 rule, the reason the two outcomes had to split (a
before*guard swallowed intofalselets writes through; an audit hook swallowed intofalsedrops records — opposite failures from one collapsed outcome), and the practical authoring consequence.Verification
node scripts/check-doc-authoring.mjs— 215 files cleanDocs-only; releases nothing.
Generated by Claude Code