Add support for descriptors been stored / loaded to/from EEPROM.#35
Open
dioannidis wants to merge 1 commit into
Open
Add support for descriptors been stored / loaded to/from EEPROM.#35dioannidis wants to merge 1 commit into
dioannidis wants to merge 1 commit into
Conversation
dioannidis
changed the title
Contributor
|
I have not looked at the repo for quite a while here on Github, so I'm a bit late to ask: The PR adds some complexity to the code (many if-conditions). Descriptors in RAM are already supported. You can achieve the same thing by copying the descriptor to RAM and serving it from there. The only advantage of this extension is to save the RAM space, right? Is there an application where RAM is so tight that you need to deliver a descriptor directly from EEPROM? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I needed in a project the ability to store and retrieve descriptors from EEPROM instead of flash or RAM . So here it is my little contribution to the project .
regards,