ci(deploy): move server identity into secrets - #127
Merged
Merged
Conversation
The deploy workflow hard-coded the SSH host alias, the login user, and the remote deploy directory in plaintext. Pull them from new repo secrets (SERVER_SSH_HOST, SERVER_USER, SERVER_DEPLOY_DIR) so the deploy target is not baked into the public workflow. GitHub masks the values in job logs. No behavioural change — same host, user, and directory, sourced indirectly.
CI has no path filter, so a docs-only merge to main runs the full pipeline and, on success, triggers a rebuild + redeploy via the deploy workflow's workflow_run hook. Add paths-ignore for markdown, docs/, and LICENSE on the push trigger so documentation edits no longer rebuild images or redeploy the server. Pull-request runs are unchanged (still validate every PR).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
deployworkflow hard-coded the deploy target in plaintext: the SSH host alias, the login user, and the remote deploy directory. Move all three into repo secrets so they are not baked into the public workflow file.Changes
SERVER_SSH_HOST,SERVER_USER,SERVER_DEPLOY_DIR(already set in the repo).Configure SSHstep: the generated~/.ssh/configHost/Usernow interpolate from$SERVER_SSH_HOST/$SERVER_USER.Shipstep:DEPLOY_DIRcomes fromsecrets.SERVER_DEPLOY_DIR; everyssh/scptarget uses$SERVER_SSH_HOST.Behaviour
No functional change — same host, user, and directory, just sourced from secrets (GitHub masks the values in job logs). YAML validated.
Note
This scrubs the current file. The values still exist in older commits in git history; a history rewrite is out of scope here and would force-push over open PR bases.