Updated dependencies on composer.json and doc on Readme.md - #107
Open
andreluizmachado wants to merge 4 commits into
Open
Updated dependencies on composer.json and doc on Readme.md#107andreluizmachado wants to merge 4 commits into
andreluizmachado wants to merge 4 commits into
Conversation
luisfn
reviewed
Mar 10, 2020
Comment on lines
+86
to
+94
| ### Running Commands | ||
|
|
||
| Please make sure that you're on the tao root folder before run the commands: | ||
|
|
||
| ```bash | ||
| $ cd /path/to/your/tao/instance | ||
| ``` | ||
|
|
||
|
|
There was a problem hiding this comment.
Not sure this new section is needed... maybe it would be more meaningful showing a real command being executed. What do you think?
Contributor
Author
There was a problem hiding this comment.
Like your suggestion, I'll need to copy and paste the same instruction on the "Running worker" and "Initializing the queues and the task log container" sections or copy and paste into 10 commands, that's why I made it separately.
Contributor
Author
There was a problem hiding this comment.
What I did was remove the section for a simple note. Could you check again, please?
luisfn
approved these changes
Mar 11, 2020
Skyld
approved these changes
Aug 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pcntl extension is required when executing worker commands.
Updated readme.md just to explain that the command should be executed in the TAO folder, not within this project.