Repository navigation
Conversation
…patíveis com 1.21.8 Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
📝 WalkthroughWalkthroughViaVersion, ViaBackwards, and ViaRewind versions are parameterized in the Docker build and updated in ChangesVia plugin version configuration
Estimated code review effort: 2 (Simple) | ~5 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)✅ Passed checks (4 passed)Full details: Title checkExplanation O título descreve a atualização dos plugins Via*, que é o objetivo principal, mas informa versões diferentes das alterações reais. O pull request atualiza ViaVersion e ViaBackwards para 5.11.0 e ViaRewind para 4.1.3.
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
Dockerfile (2)
33-37: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winMake failed downloads fail the image build.
Without
--fail, curl can return success for HTTP errors such as 404, leaving an invalid response saved as a.jar. Add--fail --show-errorto each download command. (curl.se)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Dockerfile` around lines 33 - 37, Update each curl command downloading ViaVersion, ViaBackwards, and ViaRewind in the Dockerfile to include --fail --show-error, ensuring HTTP download errors fail the image build while preserving the existing output paths and URLs.
33-37: 🩺 Stability & Availability | 🔵 TrivialEnsure the plugin volume is refreshed during upgrades.
Rebuilding the image does not replace an existing
mc-pluginsvolume, so these newly downloaded JARs may remain hidden behind stale volume contents. Keepdocker compose down -vor an explicit volume migration in the upgrade path. (docs.docker.com)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Dockerfile` around lines 33 - 37, Update the upgrade path associated with the Docker Compose deployment to refresh the mc-plugins volume when plugin JARs change. Preserve the existing plugin download behavior and either retain docker compose down -v during upgrades or add an explicit volume migration that replaces stale contents with the newly downloaded plugins.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/setup.bat`:
- Around line 6-8: Update the setup script’s plugin download flow using
VIAVERSION_VER, VIABACKWARDS_VER, and VIAREWIND_VER so that, after all new JAR
downloads succeed, it removes older versioned ViaVersion, ViaBackwards, and
ViaRewind JARs while preserving the newly downloaded files. Ensure cleanup is
scoped to matching plugin filenames and does not run before successful
downloads.
---
Nitpick comments:
In `@Dockerfile`:
- Around line 33-37: Update each curl command downloading ViaVersion,
ViaBackwards, and ViaRewind in the Dockerfile to include --fail --show-error,
ensuring HTTP download errors fail the image build while preserving the existing
output paths and URLs.
- Around line 33-37: Update the upgrade path associated with the Docker Compose
deployment to refresh the mc-plugins volume when plugin JARs change. Preserve
the existing plugin download behavior and either retain docker compose down -v
during upgrades or add an explicit volume migration that replaces stale contents
with the newly downloaded plugins.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 772cd167-eb66-4cfe-a8c5-53b94f4099e7
📒 Files selected for processing (2)
Dockerfilescripts/setup.bat
| set "VIAVERSION_VER=5.11.0" | ||
| set "VIABACKWARDS_VER=5.11.0" | ||
| set "VIAREWIND_VER=4.1.3" |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Remove obsolete plugin JARs during upgrades.
Because the version is embedded in each filename, an existing ViaVersion-5.3.0.jar, ViaBackwards-5.3.0.jar, or ViaRewind-4.0.4.jar is not removed. The next server start can see both old and new artifacts. Delete older matching JARs after the new downloads succeed, or switch to stable filenames with an explicit replacement step.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@scripts/setup.bat` around lines 6 - 8, Update the setup script’s plugin
download flow using VIAVERSION_VER, VIABACKWARDS_VER, and VIAREWIND_VER so that,
after all new JAR downloads succeed, it removes older versioned ViaVersion,
ViaBackwards, and ViaRewind JARs while preserving the newly downloaded files.
Ensure cleanup is scoped to matching plugin filenames and does not run before
successful downloads.
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <devin-ai-integration[bot]@users.noreply.github.com>
Summary
O
ViaVersionnão carrega no servidor com as versões fixadas nomain:O
Dockerfileescripts/setup.batfixavam ViaVersion/ViaBackwards 5.3.0 e ViaRewind 4.0.4, que não suportam o protocolo 1.21.8 — o suporte multi-versão estava desligado na prática. Este PR alinha as três vias de instalação (Dockerfile,setup.sh,setup.bat) nas releases mais recentes e extrai as versões paraENVno Dockerfile:(2026-09-28: bump adicional 5.11.0/4.1.3 -> 5.12.0/4.2.0, últimas releases no GitHub.)
Verificado localmente (build combinado com o #6, necessário porque o
mainainda baixa o Paper pela API v2 descontinuada):Sem nenhum
ERROR; containermc-server-1218healthy.Nota de deploy:
plugins/é um volume nomeado (mc-plugins), então o rebuild só entrega os jars novos apósdocker compose down -v(ou remoção do volume).Link to Devin session: https://app.devin.ai/sessions/d623089f3bfc4b0bb8dc92aa0cad8636
Open in Devin Desktop: https://app.devin.ai/desktop/session/d623089f3bfc4b0bb8dc92aa0cad8636?variant=devin