Repository navigation
Keep appearance tests out of the user's real defaults - #94
Merged
Merged
Conversation
AppearanceManager hardcoded UserDefaults.standard, so its tests saved and restored the user's real appearance settings around each test and could fail or leave stray values when test runs overlapped. Under XCTest it now uses a throwaway suite, like UsageStore, AliasSettings and SearchShortcutSettings already do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppearanceManager hardcoded
UserDefaults.standard, so AppearanceManagerTests, AppearanceSettingsModelTests and ResultsViewTests saved and restored the developer's real appearance settings around every test. When test runs overlapped (e.g. several worktrees at once) this caused intermittent failures such astestColorsRoundTripThroughUserDefaultsand could leave stray values behind.AppearanceManagernow takes its defaults ininit(defaults:);appDefaultsis.standardin the app and a throwaway suite (dmenu-mac.tests.appearance, wiped at startup) under XCTest — the same pattern as UsageStore, AliasSettings and SearchShortcutSettings.UserDefaults.standarddirectly now useAppearanceManager.appDefaults.testTestsNeverWriteTheRealDefaultschecks a write throughAppearanceManager.sharednever reaches the real defaults.Testing: full suite passed 3 runs in a row (374 tests),
swiftlint --strictclean, and the realappearance.*keys were unchanged afterwards.🤖 Generated with Claude Code