Repository navigation
make eval failures a regression contract - #11
Merged
Merged
Conversation
CI stays keyless and fails if frozen deny fixtures vanish or start passing.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixture evals printed a terse FAIL line. If someone deleted
policy-infinite-approve,policy-bad-recipient, orinjection-schema-junk, CI still went green. A deny that started passing would only fail if the fixture file still existed and still expected a deny.Solution
The runner prints expected vs actual on every mismatch. Those three ids are a freeze list: missing file or
ok=truefails CI even ifexpectwas edited. GitHub Actions unsetsOPENAI_API_KEY/EVAL_PLANNER/PLANNERbeforenpm test. Adding a fixture is documented inpackages/evals/README.md.How to test
Unit tests cover a vanished freeze id and a freeze case that starts passing. CI eval job must stay keyless.