Skip to content

Version partner event JSON and fail closed - #27

Merged
o-mid merged 4 commits into
developfrom
feat/event-schema-version
Sep 18, 2026
Merged

o-mid merged 4 commits into
developfrom
feat/event-schema-version

Conversation

@o-mid

@o-mid o-mid commented Sep 18, 2026 •

Copy link
Copy Markdown
Owner

Problem

Partner events had no schema version, so a future field change would look like a valid v1 body.

Solution

schema_version omitted or 1 still accepts. Unknown versions return 400. Replay packs are unchanged. Heartbeats still do not credit.

How to test

go test ./internal/ingest ./internal/api/httpapi -count=1 -run 'TestValidateEvent|TestIngestRejectsUnknown|TestIngestAcceptsV1'
make replay

@vercel

vercel Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
engagepulse Ready Ready Preview Sep 18, 2026 9:49am UTC

@o-mid
o-mid merged commit 7c3cf3a into develop Sep 18, 2026
4 checks passed
@o-mid
o-mid deleted the feat/event-schema-version branch September 18, 2026 09:51

This branch was successfully deployed

1 active deployment
Preview — b532fa40 Deployed Sep 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant