Fix DirectUnpack finalization after PAR failure - #869
Open
xbmc4lyfe wants to merge 4 commits into
Open
Conversation
Allow successful direct unpack jobs to complete normal unpack finalization even when a forced PAR check fails. Preserve the existing PAR failure status and skip behavior for direct unpack jobs that did not succeed. Fixes nzbgetcom#748
xbmc4lyfe
force-pushed
the
codex/fix-748-directunpack-status
branch
from
July 19, 2026 16:26
ec3cdb5 to
20aeddc
Compare
dnzbk
self-requested a review
July 21, 2026 16:03
dnzbk
reviewed
Jul 21, 2026
Collaborator
|
@xbmc4lyfe Could you update POST-PROCESSING.md to clarify that |
…ctunpack-status # Conflicts: # tests/postprocess/DirectUnpack.cpp
Extract MakeParFailureTestOpts()/QueueParFailureTestNzb() so the two new tests share cmdopts/NzbInfo setup instead of duplicating it, per review feedback that the added test code was heavy for a 1-line fix. The full-lifecycle test still drives the real async pipeline: StartJob is private and only reachable through PrePostProcessor's real Run() loop, and UnpackController::CheckArchiveFiles() decides whether to reuse already-extracted files based on bookkeeping only a real DirectUnpack pass populates, so a narrower unit-level test of the condition alone isn't achievable without refactoring production code beyond this fix's scope.
Clarify in POST-PROCESSING.md that when DirectUnpack already extracted a download successfully, unpack still finalizes (UNPACKSTATUS=2) even if the par-check that runs afterward fails (PARSTATUS=1), and that the overall NZBPP_STATUS still reflects the par failure.
Contributor
Author
|
@dnzbk Done in 12fba7a — added a note under (A prior reply to this comment appears to have gone missing — reposting to make sure this lands.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Fixes #748