Makefile: don't override LDFLAGS - #24
Open
thejh wants to merge 1 commit into
Open
Conversation
Since commit 64311c8, LDFLAGS is overridden by "LDFLAGS =", causing linker flags specified by the caller to be ignored. This seems to have been an accident while moving things around - delete that line. This makes the QEMU-Nyx static build work again for me; otherwise, libcapstone.so.4 can't be found. (I'm not going to ask why a static build involves a shared library in the first place...)
|
I also ran into this when trying to build AFL++ Nyx mode. QEMU-Nyx sets It would be great if this simple fix could be merged. |
morehouse
approved these changes
Dec 12, 2025
morehouse
left a comment
morehouse
left a comment
There was a problem hiding this comment.
LGTM, this is how I fixed my build issues locally as well.
fanquake
added a commit
to fanquake/QEMU-Nyx
that referenced
this pull request
Jan 5, 2026
|
+1. Would be great to land this (closes #23). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since commit 64311c8, LDFLAGS is overridden by "LDFLAGS =", causing linker flags specified by the caller to be ignored.
This seems to have been an accident while moving things around - delete that line.
This makes the QEMU-Nyx static build work again for me; otherwise, libcapstone.so.4 can't be found.
(I'm not going to ask why a static build involves a shared library in the first place...)