Skip to content

Kubernetes OpenAPI spec compatibility #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
curiousleo wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Kubernetes OpenAPI spec compatibility #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28d3d44
Generate proto for Kubernetes OpenAPI spec
curiousleo Sep 16, 2020
0adc908
Remove debug logging
curiousleo Sep 16, 2020
f408633
Allow primitive request types, for symmetry
curiousleo Sep 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions compiler/compiler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,7 @@ func (c *compileCtx) compilePath(path string, p *openapi.Path) error {
if err != nil {
return errors.Wrapf(err, `failed to compile parameters for %s`, endpointName)
}
reqType = c.getBoxedType(reqType)
m, ok := reqType.(*protobuf.Message)
if !ok {
return errors.Errorf(`type %s is not a message (%T)`, reqName, reqType)
Expand Down Expand Up @@ -388,6 +389,7 @@ func (c *compileCtx) compilePath(path string, p *openapi.Path) error {
}

if resType != nil {
resType = c.getBoxedType(resType)
m, ok := resType.(*protobuf.Message)
if !ok {
return errors.Errorf(`got non-message type (%T) in response for %s`, resType, endpointName)
Expand Down
Loading