Fix OAuth device verification JavaScript to use correct service endpoints#583
Merged
Fix OAuth device verification JavaScript to use correct service endpoints#583
Conversation
…ints The device verification page (served by campus.auth) was making JavaScript fetch requests to /api/v1/users/me and /api/v1/oauth/device/authorize. These paths route to campus.api service (different domain), so the Flask session cookie from campus.auth wasn't being sent, causing authentication checks to fail after Google OAuth login. Changes: - Add /oauth/users/me endpoint in campus.auth that returns current user from Flask session (no bearer token required) - Change JavaScript fetch URLs to use relative paths (./users/me and ./authorize) to keep requests within campus.auth service - Add test for the new /oauth/users/me endpoint Fixes issue where device authorization showed "You must be logged in to authorize a device" error immediately after successful Google authentication. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The device verification page (served by campus.auth) was making JavaScript fetch requests to
/api/v1/users/meand/api/v1/oauth/device/authorize. These paths route to campus.api service (different domain), so the Flask session cookie from campus.auth wasn't being sent, causing authentication checks to fail after Google OAuth login.Changes
/oauth/users/meendpoint in campus.auth that returns current user from Flask session (no bearer token required)./users/meand./authorize) to keep requests within campus.auth service/oauth/users/meendpointFixes
Fixes issue where device authorization showed "You must be logged in to authorize a device" error immediately after successful Google authentication when using
campus auth loginCLI command.Test Plan
/oauth/users/meendpoint passes🤖 Generated with Claude Code