fix(deploy): add ProxyFix middleware for correct redirect URLs#582
Merged
fix(deploy): add ProxyFix middleware for correct redirect URLs#582
Conversation
When running behind a reverse proxy (Railway, Nginx, etc.), Flask's url_for(..., _external=True) was generating HTTP URLs instead of HTTPS, causing redirect scheme mismatch issues. This commit adds werkzeug.middleware.proxy_fix.ProxyFix to handle X-Forwarded-* headers sent by Railway: - X-Forwarded-Proto: sets correct URL scheme (https vs http) - X-Forwarded-Host: preserves original host - X-Forwarded-For: passes through client IP - X-Forwarded-Prefix: handles subpath routing This ensures OAuth redirect URLs use the correct HTTPS scheme, fixing login flows and other redirects in production deployment. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When running behind a reverse proxy (Railway, Nginx, etc.), Flask's
url_for(..., _external=True)was generating HTTP URLs instead of HTTPS, causing redirect scheme mismatch issues.This commit adds
werkzeug.middleware.proxy_fix.ProxyFixto handleX-Forwarded-*headers sent by Railway:X-Forwarded-Proto: sets correct URL scheme (https vs http)X-Forwarded-Host: preserves original hostX-Forwarded-For: passes through client IPX-Forwarded-Prefix: handles subpath routingThis ensures OAuth redirect URLs use the correct HTTPS scheme, fixing login flows and other redirects in production deployment.
Test plan
Investigation notes
The OAuth redirect codepath was working correctly (tests pass, 302 redirect happens), but the generated redirect URL used
httpinstead ofhttps. This is a common issue when Flask runs behind a reverse proxy that terminates SSL.🤖 Generated with Claude Code