Open
Conversation
nwoltman
reviewed
Mar 28, 2023
Owner
nwoltman
left a comment
nwoltman
left a comment
There was a problem hiding this comment.
I just realized CI didn't run because Travis CI changed since I last had any updates happy to this package. I'm going to work on migrating to GitHub Actions.
Comment on lines
+42
to
+47
| "grunt-jsdoc-to-markdown": "^6.0.0", | ||
| "grunt-mocha-istanbul": "^5.0.2", | ||
| "grunt-mocha-test": "^0.13.3", | ||
| "istanbul": "^0.4.5", | ||
| "jit-grunt": "^0.10.0", | ||
| "mocha": "^7.0.1", | ||
| "mocha": "^10.2.0", |
Owner
There was a problem hiding this comment.
Would you mind undoing these? I know the devDepencies are out of date, but these sorts of changes should be done separately.
Comment on lines
+50
to
+51
| const poolConfig = mysql.createPool(config).config; | ||
| super({config: poolConfig}); |
Owner
There was a problem hiding this comment.
It looks like you're trying to be less hacky, but this is going to create an extra, unused pool. This code doesn't need to change if you do the suggestion I'll post above.
| const PoolConfig = require('mysql/lib/PoolConfig'); | ||
| const SqlString = require('mysql/lib/protocol/SqlString'); | ||
| const {Pool} = require('mysql2'); | ||
| const mysql = require('mysql2'); |
Owner
There was a problem hiding this comment.
Suggested change
| const mysql = require('mysql2'); | |
| const PoolConfig = require('mysql2/lib/pool_config'); |
nwoltman
force-pushed
the
master
branch
2 times, most recently
from
7d235ad to
ee6682e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error: ER_NOT_SUPPORTED_AUTH_MODE: Client does not support authentication protocol requested by server; consider upgrading MySQL clientThe original mysql library is outdated (last update 3 years ago) and it doesn't support modern MySQL servers. This change updates the library to use mysql2.
Also - thanks for building this library!