feat(deploy): restore reusable-terraform-deploy.yaml#61
Merged
Conversation
The deploy reusable has been authored on an unmerged feature branch (chore/standardize-fleet-bead9a4) since commit 2fe1bce. Multiple iter- ations followed (last touched in 12ad292), but the branch was never opened as a PR and main moved on. Meanwhile, every github-terraform- runner repo's caller pins uses: nwarila-platform/github-terraform-framework/.github/workflows/ reusable-terraform-deploy.yaml@<framework-main-sha> which 404s because the file was never on main. The deploys silently worked through 2026-05-21 because runner repos hadn't touched `terraform/**` and the workflow filter never fired; today's PR #38 on github-terraform-runner was the first push to `terraform/**` since the deletion gap was introduced, and it failed at the workflow- resolution stage before any job ran. This restores the reusable from commit 12ad292: .github/workflows/reusable-terraform-deploy.yaml (442 lines) Brought across verbatim — no functional changes — so the existing caller signature matches: inputs: github_owner, framework_ref, terraform_version, private_repos_files, private_repos_prefix secrets: aws_role_arn, aws_region, backend_bucket, gh_token `.gitignore` allowlists the new file per the deny-all strategy. Validated locally: actionlint clean; zizmor `No findings to report` (2 suppressed) against the reusable workflow file. Once this lands, every `*-runner` repo's `terraform-deploy.yaml` SHA pin needs to be bumped to the new framework main HEAD — a follow-up PR per runner repo (or a Renovate bump). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Terraform Framework Test Results
Runs: 55 total, 55 passed, 0 failed, 0 skipped Full test outputCommit: ec12fe8 |
Merged
2 tasks
NWarila
added a commit
to NWarila/github-terraform-runner
that referenced
this pull request
May 25, 2026
## Summary Bumps the `uses:` SHA and `framework_ref:` input in `.github/workflows/terraform-deploy.yaml` to the new framework main HEAD after [nwarila-platform/github-terraform-framework#61](nwarila-platform/github-terraform-framework#61) restored the reusable workflow. | | Before | After | | --- | --- | --- | | `uses:` SHA | `f3c05b7f...` | `0b99965b...` | | `framework_ref:` | `f3c05b7f...` | `0b99965b...` | ## Why PR #38 (`add-packer-runner-template inventory entry`) was the first push to `terraform/**` since the framework's `reusable-terraform-deploy.yaml` deletion gap was introduced. The deploy [failed at workflow resolution](https://github.com/NWarila/github-terraform-runner/actions/runs/26422245446). nwarila-platform/github-terraform-framework#61 restored the reusable; this PR re-points the runner at the restored file. ## Test plan - [ ] PR validation green - [ ] After merge, `Deploy GitHub Terraform` workflow succeeds and creates `NWarila/packer-runner-template` ## Verification - Local contract validator: `52 passed, 0 failed` - Local actionlint: clean Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores
.github/workflows/reusable-terraform-deploy.yamltomain(442 lines, verbatim from commit12ad292on the unmergedchore/standardize-fleet-bead9a4branch). Allowlists the file in.gitignoreper the deny-all strategy.Why
Every
*-runnerrepo'sterraform-deploy.yamlcaller pins:That file has never been on
main. The deploys silently worked through 2026-05-21 because runner repos hadn't touchedterraform/**and the workflow filter never fired; today'sNWarila/github-terraform-runner#38was the first push toterraform/**since the gap was introduced, and it failed at workflow resolution before any job ran.The unmerged branch had ~10 iterations of bug fixes against the reusable (
fix(deploy): use terraform console flag order,fix(deploy): show ruleset console errors,fix(deploy): adopt existing rulesets before plan, etc.). Bringing the tip of that work (12ad292) onto main captures all that prior debugging.Caller signature (already in place across all runner repos)
| Inputs |
github_owner,framework_ref,terraform_version,private_repos_files,private_repos_prefix|| Secrets |
aws_role_arn,aws_region,backend_bucket,gh_token|Test plan
terraform/, drift-gate, security)actionlintagainst the new file (local: clean)zizmoragainst the new file (local: 0 findings, 2 suppressed)NWarila/github-terraform-runner/.github/workflows/terraform-deploy.yaml(and any other runner repo) — follow-up PR.Follow-up
After this lands, the runner's
terraform-deploy.yamluses:SHA +framework_ref:input must move to the new frameworkmainHEAD. Renovate'sgit-refsdatasource will eventually propose the bump; a manual PR can move it sooner so thatNWarila/packer-runner-templategets created from the still-pending inventory entry.