fix(docs-check): allow ADRs under docs/decision-records/template/#60
Merged
Conversation
PR #44 added docs/decision-records/template/0001-pin-terraform-and- provider-versions-exactly.md but check_docs_layout.py was not updated to include the template tier in ADR_ALLOWED_SUBTREES. The framework's own CI workflow does not run `make ci` (only terraform fmt/init/ validate/test) so this never failed framework-side, but the runner's contract-validation pipeline does call `make ci` against the framework checkout and that surfaces the layout error. Aligns with the template-tier ADR convention used by the four template repos (terraform-framework-template, terraform-runner-template, ansible-framework-template, packer-framework-template) which all include 'template' in ADR_ALLOWED_SUBTREES. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Terraform Framework Test Results
Runs: 55 total, 55 passed, 0 failed, 0 skipped Full test outputCommit: f7c088c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/check_docs_layout.pywas not updated when PR #44 introduced the template-tier ADR. The framework's own CI workflow only runs terraform fmt/init/validate/test, so this never failed framework-side, but consumers (github-terraform-runner) that runmake ciagainst this framework as part of contract validation surface the layout error.Aligns with the convention in all four template repos which already include 'template' in ADR_ALLOWED_SUBTREES.
Test plan