Fix deprecated vim.lsp.diagnostic.get_count call#226
Open
CHNB128 wants to merge 1 commit intonvimdev:mainfrom
Open
Fix deprecated vim.lsp.diagnostic.get_count call#226CHNB128 wants to merge 1 commit intonvimdev:mainfrom
vim.lsp.diagnostic.get_count call#226CHNB128 wants to merge 1 commit intonvimdev:mainfrom
Conversation
CHNB128
force-pushed
the
main
branch
3 times, most recently
from
1e1a6bc to
bc079ff
Compare
carrascomj
reviewed
Jan 27, 2022
| count = count + lsp.diagnostic.get_count(api.nvim_get_current_buf(),diag_type,client.id) | ||
| local opts = { severity = diag_type } | ||
| opts.namespace = vim.diagnostic.get_namespace(client.id) | ||
| count = count + vim.diagnostic.get(api.nvim_get_current_buf(),opts) |
There was a problem hiding this comment.
This patch gives arithmetic errors when displaying the diagnostics at the galaxystatus line.
I may be wrong, but aren't you here adding a scalar count to a table from vim.diagnostic.get().
There was a problem hiding this comment.
I've fixed this in my fork if you're interested.
https://github.com/justinhj/galaxyline.nvim/blob/main/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.