Skip to content

fix: parse() call for Neovim 0.10+ API #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eric-chapdelaine wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix: parse() call for Neovim 0.10+ API #674

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
537f336
fix: parse() call for Neovim 0.10+ API
eric-chapdelaine May 18, 2026
f5c3809
fix: add version check for parse() API compatibility
eric-chapdelaine May 18, 2026
441d8ed
fix: use pcall to handle parse() API differences
eric-chapdelaine May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lua/treesitter-context/context.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,11 @@ local function get_parent_langtrees(bufnr, range)
return {}
end

--- @diagnostic disable-next-line:redundant-parameter added in 0.11
root_tree:parse(range, function(...) end)
local function try_parse(tree, r, cb)
local ok = pcall(function() tree:parse({ r }, cb) end)
if not ok then tree:parse(r, cb) end
end
try_parse(root_tree, range, function(...) end)
Comment on lines +238 to +242

@romgrk romgrk May 19, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So pcall() is just to fix some test environment error? Feels wrong to use it :/

@eric-chapdelaine eric-chapdelaine May 20, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree! I didn't mean to set this PR as ready to review just yet. Let me play around with this more and I will message you when it's ready for review.

local ret = { root_tree }

while true do
Expand Down
Loading