Add holoscan-cli tool-runner alias#190
Merged
Merged
Conversation
Add a holoscan-cli console script alias so package-name based tool runners can execute the CLI directly while keeping holoscan as the canonical command. Extend wheel smoke coverage and CI tool-runner checks for uvx and pipx run. Co-authored-by: Codex <noreply@openai.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
WalkthroughThis PR extends holoscan-cli packaging to support tool-runner execution (uvx/pipx) by adding a ChangesTool-runner CLI Alias Support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yaml:
- Around line 279-282: Add an explicit least-privilege permissions block to the
smoke-test job so it does not inherit full workflow token rights; in the job
definition that contains the steps "Install tool runners" and "Tool-runner smoke
test" add a permissions entry (e.g., permissions: contents: read) to restrict
the workflow token to only what the job needs and reduce its blast radius.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4138c290-29c1-478f-bb4d-a11adb39f1c2
📒 Files selected for processing (7)
.github/scripts/smoke_test.sh.github/scripts/tool_runner_smoke.sh.github/workflows/main.yaml.github/workflows/release.yamlREADME.mdpyproject.tomltests/unit/test_package_data.py
jcfr
reviewed
Jun 12, 2026
tbirdso
approved these changes
Jun 12, 2026
jcfr
approved these changes
Jun 12, 2026
wyli
added a commit
that referenced
this pull request
Jun 15, 2026
Add a holoscan-cli console script alias so package-name based tool runners can execute the CLI directly while keeping holoscan as the canonical command. Extend wheel smoke coverage and CI tool-runner checks for uvx and pipx run. Co-authored-by: Codex <noreply@openai.com> (cherry picked from commit a0416b0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
holoscan-clias a console-script alias for package-name based tool runnersuvxandpipx runusage while keepingholoscanas the primary commandTesting
python -m pytest -q -o addopts='' tests/unitpython -m build --wheel --outdir /tmp/holoscan-cli-build.3YvykB.github/scripts/smoke_test.sh /tmp/holoscan-cli-smoke.djy10k/bin.github/scripts/tool_runner_smoke.sh /tmp/holoscan-cli-build.3YvykBAI-assisted: Created with Codex/GPT at the user's request.
Summary by CodeRabbit
New Features
holoscan-clientrypoint as a tool-runner compatible alias for transient command execution viauvxandpipx run.Documentation
holoscan-cliwith external tool runners for non-installed environments.Tests
holoscanandholoscan-clientrypoints.