Skip to content

Honor CTest script env override before container run#189

Merged
wyli merged 1 commit into
release/4.3.0from
wenqil/ctest-script-env-override
Jun 12, 2026
Merged

Honor CTest script env override before container run#189
wyli merged 1 commit into
release/4.3.0from
wenqil/ctest-script-env-override

Conversation

@wyli

@wyli wyli commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • render HOLOSCAN_CLI_CTEST_SCRIPT as a literal ctest -S argument before entering app containers
  • keep the existing in-container Python fallback only when no explicit CLI/env override is configured
  • add helper-level and command-level regression tests for the env override path

Tests

  • PYTHONPATH=src PYTHONDONTWRITEBYTECODE=1 python -m pytest -q -o addopts='' -p no:cacheprovider tests/unit/test_container_recursion.py tests/unit/test_lifecycle_commands.py
  • PYTHONPATH=src PYTHONDONTWRITEBYTECODE=1 python -m pytest -q -o addopts='' -p no:cacheprovider tests/unit
  • PYTHONPATH=src RUFF_CACHE_DIR=/tmp/holoscan-cli-ruff-cache python -m ruff check src/holoscan_cli/commands/test_cmd.py tests/unit/test_container_recursion.py tests/unit/test_lifecycle_commands.py
  • python -m black --check src/holoscan_cli/commands/test_cmd.py tests/unit/test_container_recursion.py tests/unit/test_lifecycle_commands.py
  • python -m isort --check-only src/holoscan_cli/commands/test_cmd.py tests/unit/test_container_recursion.py tests/unit/test_lifecycle_commands.py
  • PRE_COMMIT_HOME=/tmp/holoscan-cli-pre-commit-cache python -m pre_commit run --show-diff-on-failure --files src/holoscan_cli/commands/test_cmd.py tests/unit/test_container_recursion.py tests/unit/test_lifecycle_commands.py

AI-assisted: Created with Codex/GPT at the user's request.

Render HOLOSCAN_CLI_CTEST_SCRIPT as a literal ctest -S argument when constructing test commands. This lets source-project wrappers provide a mounted CTest script without requiring holoscan-cli to be importable inside application containers.

Co-authored-by: Codex <noreply@openai.com>
@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@wyli wyli requested a review from tbirdso June 11, 2026 18:00
@wyli wyli merged commit 4dd1e2b into release/4.3.0 Jun 12, 2026
27 checks passed
@wyli wyli deleted the wenqil/ctest-script-env-override branch June 12, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants