fix: replace 'holoscan-cli v1' with 'since holoscan v4.3.0' in removed-command errors#184
fix: replace 'holoscan-cli v1' with 'since holoscan v4.3.0' in removed-command errors#184wyli wants to merge 1 commit into
Conversation
…d-command errors 'holoscan-cli v1' is an internal codename that means nothing to users. Reference the public release version instead so the message is clear. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Warning Review limit reached
More reviews will be available in 37 minutes and 57 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…n convention holoscan-cli now versions in lockstep with the Holoscan SDK, so the internal "v1" codename is meaningless to users. Replace it with the public release version (holoscan v4.3.0) everywhere it appears in user-facing messaging: - src/holoscan_cli/__main__.py: removed-command error + footer strings and the explanatory comments - README.md: HOLOHUB_* env-var deprecation note and the HAP/MAP packaging deprecation section - tests/unit/test_main.py: pin the new "since holoscan v4.3.0" wording Supersedes the split work in #184 and #185. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Superseded by #185, which unifies this change with the comment + README.md updates and the test fix into a single PR. Closing to keep one PR for the messaging work. |
…n convention (#185) * fix: align removed-command and HAP/MAP messaging with holoscan version convention holoscan-cli now versions in lockstep with the Holoscan SDK, so the internal "v1" codename is meaningless to users. Replace it with the public release version (holoscan v4.3.0) everywhere it appears in user-facing messaging: - src/holoscan_cli/__main__.py: removed-command error + footer strings and the explanatory comments - README.md: HOLOHUB_* env-var deprecation note and the HAP/MAP packaging deprecation section - tests/unit/test_main.py: pin the new "since holoscan v4.3.0" wording Supersedes the split work in #184 and #185. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix: document SDK pin for legacy HAP/MAP packaging Co-authored-by: Codex <noreply@openai.com> * fix: wrap HAP MAP deprecation note Co-authored-by: Codex <noreply@openai.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Codex <noreply@openai.com>
1 participant
Summary
__main__.py, the error messages shown when a user runs a removed command (e.g.holoscan nics) referenced the internal codename "holoscan-cli v1", which is meaningless to end usersBefore:
After:
Test plan
holoscan nicsand confirm the updated error message is printed to stderr🤖 Generated with Claude Code