fix: bug in workflows job lookup + improve dependency deploys#1698
Open
jonmorehouse wants to merge 8 commits into
Open
fix: bug in workflows job lookup + improve dependency deploys#1698jonmorehouse wants to merge 8 commits into
jonmorehouse wants to merge 8 commits into
Conversation
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a long-standing bug where some workflows could fail with a "deploy not found" error. The
GetInstallDeployForApplyStepquery usedComponentIDin a GORM struct-basedWhereclause, butComponentIDonInstallDeployisgorm:"-"— so GORM silently dropped the filter. The actual query only matched oninstall_workflow_id, returning the most recent deploy in the workflow regardless of component. When image dependency syncs created a newer deploy in the same workflow, the apply step would pick up the wrong one.Fixed by joining through
install_componentsto filter on the realcomponent_idcolumn.Additionally, deploying upstream image dependencies is now opt-in. Previously, a manual deploy would always sync any images the component depends on. Now you must explicitly pass
--dependency-imageson the CLI (or check "Sync dependency images" in the dashboard) to include those sync steps.