Skip to content

fix: bug in workflows job lookup + improve dependency deploys#1698

Open
jonmorehouse wants to merge 8 commits into
mainfrom
jm/fix-manual-deploys
Open

fix: bug in workflows job lookup + improve dependency deploys#1698
jonmorehouse wants to merge 8 commits into
mainfrom
jm/fix-manual-deploys

Conversation

@jonmorehouse

@jonmorehouse jonmorehouse commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Fixes a long-standing bug where some workflows could fail with a "deploy not found" error. The GetInstallDeployForApplyStep query used ComponentID in a GORM struct-based Where clause, but ComponentID on InstallDeploy is gorm:"-" — so GORM silently dropped the filter. The actual query only matched on install_workflow_id, returning the most recent deploy in the workflow regardless of component. When image dependency syncs created a newer deploy in the same workflow, the apply step would pick up the wrong one.

Fixed by joining through install_components to filter on the real component_id column.

Additionally, deploying upstream image dependencies is now opt-in. Previously, a manual deploy would always sync any images the component depends on. Now you must explicitly pass --dependency-images on the CLI (or check "Sync dependency images" in the dashboard) to include those sync steps.

@github-actions

Copy link
Copy Markdown

This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed.

@github-actions github-actions Bot added the stale label Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants