feat: (ctl-api) surface composite error when a component build has failed#1689
Draft
onprem wants to merge 1 commit into
Draft
feat: (ctl-api) surface composite error when a component build has failed#1689onprem wants to merge 1 commit into
onprem wants to merge 1 commit into
Conversation
…iled
When a component deploy targets a build in a terminal failure state
(error / policy_failed), freeze a typed ComponentBuildUnavailableError
onto the InstallDeploy so the dashboard guides the user to rebuild the
component, instead of showing a raw status string or hanging on polling.
- Add ComponentBuildUnavailableError composite error type (reason
"failed"; "missing" reserved for a follow-up)
- Add RecordDeployBuildUnavailableCompositeError activity to record it
onto InstallDeploy.composite_error (best-effort, mirrors the AWS
permission flow)
- componentdeploysyncandplan signal:
- record the composite error when build polling fails on a terminal
build state
- treat policy_failed as terminal so the deploy fails fast instead of
polling for up to an hour
- prefer the latest active build over latest-any when resolving an
empty BuildID, so a newer errored build can't mask an older
deployable one
- set the workflow step's deploy target before polling so the error is
visible in the dashboard even when the build never becomes deployable
No frontend changes: the existing CompositeError renderer surfaces it on
the deploy page. Follow-up will cover truly-missing builds via a
WorkflowStep-level composite error.
jonmorehouse
approved these changes
Jun 16, 2026
jonmorehouse
left a comment
jonmorehouse
left a comment
Contributor
There was a problem hiding this comment.
This looks solid to me!
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a component deploy targets a build in a terminal failure state (error / policy_failed), freeze a typed
ComponentBuildUnavailableErroronto theInstallDeployso the dashboard guides the user to rebuild the component, instead of showing a raw status string or hanging on polling.ComponentBuildUnavailableErrorcomposite error type (reason "failed"; "missing" reserved for a follow-up)RecordDeployBuildUnavailableCompositeErroractivity to record it ontoInstallDeploy.composite_error(best-effort)componentdeploysyncandplansignal:policy_failedas terminal so the deploy fails fast instead of polling for up to an hourNo frontend changes: the existing
CompositeErrorrenderer surfaces it on the deploy page. Follow-up will cover truly-missing builds via a WorkflowStep-level composite error.