Fall back to discontinous reads of discrete outputs#31
Draft
alexrudd2 wants to merge 1 commit intosim-exceptionsfrom
Draft
Fall back to discontinous reads of discrete outputs#31alexrudd2 wants to merge 1 commit intosim-exceptionsfrom
alexrudd2 wants to merge 1 commit intosim-exceptionsfrom
Conversation
Collaborator
Author
|
Interesting, apparently we can now do drafts for public repos, but not private?! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure of my approach here, hence the separate branch.
This more or less works, although in my case trying to read ~180 tags sequentially takes >1 s and so the regular controller
read()loop timesout unless I slow it down. It also generates a lot of logging if you have many broken writes! Would it be smarter to stop polling addresses with some sort of blacklist if they return an exception?Also, this error was introduced but doesn't appear to affect anything?