Conversation
Signed-off-by: Kushal Batra <i.kushalbatra@gmail.com>
Signed-off-by: Kushal Batra <i.kushalbatra@gmail.com>
Signed-off-by: Kushal Batra <i.kushalbatra@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
==========================================
- Coverage 92.11% 92.02% -0.10%
==========================================
Files 97 99 +2
Lines 4782 4900 +118
Branches 430 442 +12
==========================================
+ Hits 4405 4509 +104
- Misses 279 289 +10
- Partials 98 102 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kushal Batra <i.kushalbatra@gmail.com>
Signed-off-by: Kushal Batra <i.kushalbatra@gmail.com>
Signed-off-by: Kushal Batra <i.kushalbatra@gmail.com>
Signed-off-by: Kushal Batra <i.kushalbatra@gmail.com>
Signed-off-by: Kushal Batra <i.kushalbatra@gmail.com>
ab93
reviewed
Aug 6, 2024
|
|
||
| def _check_data_format(df) -> bool: | ||
| if not isinstance(df, pd.DataFrame): | ||
| raise TypeError("df should be of type pd.DataFrame") |
Member
There was a problem hiding this comment.
Can you cover these lines with tests?
| def predict_horizon(self, df: pd.DataFrame) -> np.ndarray: | ||
| _check_data_format(df) | ||
| transformed_test_data = CovariatesGenerator().transform(df) | ||
| _LOGGER.info("Predicting the horizon") |
pyproject.toml
Outdated
| pydruid = { version = "^0.6", optional = true } | ||
| PyMySQL = { version = "^1.1.0", optional = true } | ||
| xgboost = "^2.1.0" | ||
| darts = "^0.30.0" |
Member
There was a problem hiding this comment.
change this to use a lighter version. Also add a TODO to remove this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: We will have to revisit on how to optimize imports for xgboost and darts