fix: calc pending and watermark for ordered#3286
Merged
Conversation
…g is set Signed-off-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3286 +/- ##
==========================================
- Coverage 80.97% 80.87% -0.10%
==========================================
Files 316 316
Lines 72203 72228 +25
==========================================
- Hits 58468 58417 -51
- Misses 13182 13254 +72
- Partials 553 557 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yhl25
reviewed
Mar 3, 2026
| isReduce := vtx.IsReduceUDF() | ||
| // Check if ordered processing is enabled for the vertex | ||
| // When ordered processing is enabled, each pod handles a specific partition (1:1 mapping like reduce) | ||
| isOrderedProcessing := vtx.GetEffectiveOrderedConfig(r.pipeline.Spec.Ordered) |
Contributor
There was a problem hiding this comment.
Can we make it like vtx.IsOrdered() ?
Comment on lines
+826
to
+833
| // Test vertex-level ordered override | ||
| vtxOrderedP := &v1alpha1.Pipeline{ | ||
| ObjectMeta: metav1.ObjectMeta{Name: "p", Namespace: "default"}, | ||
| Spec: v1alpha1.PipelineSpec{ | ||
| Vertices: []v1alpha1.AbstractVertex{ | ||
| {Name: "ordered", Scale: v1alpha1.Scale{LookbackSeconds: &lookBackSeconds}, UDF: &v1alpha1.UDF{}, Ordered: &v1alpha1.Ordered{Enabled: true}}, | ||
| {Name: "not-ordered", Scale: v1alpha1.Scale{LookbackSeconds: &lookBackSeconds}, UDF: &v1alpha1.UDF{}}, | ||
| }, |
Contributor
There was a problem hiding this comment.
Do we need to test this part here?
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com>
yhl25
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to get data from all pods since there is 1:1 for pod to partition
Closes: #3275