Skip to content

test: tests for source forwarder using simple buffer ISB#3283

Draft
vaibhavtiwari33 wants to merge 3 commits intomainfrom
source-forwarder-tests
Draft

test: tests for source forwarder using simple buffer ISB#3283
vaibhavtiwari33 wants to merge 3 commits intomainfrom
source-forwarder-tests

Conversation

@vaibhavtiwari33
Copy link
Contributor

@vaibhavtiwari33 vaibhavtiwari33 commented Mar 2, 2026

What this PR does / why we need it

tests for source forwarder using simple buffer ISB

Testing

this is the test

Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

❌ Patch coverage is 96.57795% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.95%. Comparing base (6e9f6b2) to head (4ca414d).

Files with missing lines Patch % Lines
...ow-core/src/pipeline/forwarder/source_forwarder.rs 96.53% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3283      +/-   ##
==========================================
+ Coverage   80.89%   80.95%   +0.05%     
==========================================
  Files         316      316              
  Lines       72167    72427     +260     
==========================================
+ Hits        58383    58634     +251     
- Misses      13234    13241       +7     
- Partials      550      552       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vaibhavtiwari33 vaibhavtiwari33 self-assigned this Mar 2, 2026
@vaibhavtiwari33 vaibhavtiwari33 added the testing Testing and CI label Mar 2, 2026
@vaibhavtiwari33 vaibhavtiwari33 marked this pull request as ready for review March 2, 2026 18:26

// Test source forwarder with a single output stream using SimpleBuffer.
// Reads from a UD source and writes to a SimpleBuffer-backed ISB for verification.
#[tokio::test(flavor = "multi_thread")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have to make it multi_thread? default is single thread? what will happen if we do not make it multi threaded?

Copy link
Contributor Author

@vaibhavtiwari33 vaibhavtiwari33 Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be fine in this case tbh. I added this since the UDSource was to be spawned in a separate os thread, but it will not affect the outcome here if we remove multi-thread

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's figure out why multi_thread is really required only for failure path.

@vaibhavtiwari33 vaibhavtiwari33 changed the title test: tests for source forwader using simple buffer ISB test: tests for source forwarder using simple buffer ISB Mar 2, 2026
@vaibhavtiwari33 vaibhavtiwari33 marked this pull request as draft March 3, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Testing and CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants