test: tests for source forwarder using simple buffer ISB#3283
Draft
vaibhavtiwari33 wants to merge 3 commits intomainfrom
Draft
test: tests for source forwarder using simple buffer ISB#3283vaibhavtiwari33 wants to merge 3 commits intomainfrom
vaibhavtiwari33 wants to merge 3 commits intomainfrom
Conversation
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3283 +/- ##
==========================================
+ Coverage 80.89% 80.95% +0.05%
==========================================
Files 316 316
Lines 72167 72427 +260
==========================================
+ Hits 58383 58634 +251
- Misses 13234 13241 +7
- Partials 550 552 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…of NoOpRateLimiter Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
vigith
reviewed
Mar 2, 2026
|
|
||
| // Test source forwarder with a single output stream using SimpleBuffer. | ||
| // Reads from a UD source and writes to a SimpleBuffer-backed ISB for verification. | ||
| #[tokio::test(flavor = "multi_thread")] |
Member
There was a problem hiding this comment.
why do we have to make it multi_thread? default is single thread? what will happen if we do not make it multi threaded?
Contributor
Author
There was a problem hiding this comment.
It should be fine in this case tbh. I added this since the UDSource was to be spawned in a separate os thread, but it will not affect the outcome here if we remove multi-thread
Member
There was a problem hiding this comment.
let's figure out why multi_thread is really required only for failure path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
tests for source forwarder using simple buffer ISB
Testing
this is the test