Conversation
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
whynowy
reviewed
Dec 12, 2025
| return err | ||
| } | ||
| opts = append(opts, isbsvc.WithConfig(isbSvcConfig.JetStream.StreamConfig)) | ||
| if dedupWindow != "" { |
Member
There was a problem hiding this comment.
What happens if ppl update the delivery semantics to an existing pipeline?
| } | ||
| if p.Spec.Lifecycle.DeprecatedDeleteGracePeriodSeconds != nil { | ||
| return *p.Spec.Lifecycle.DeprecatedDeleteGracePeriodSeconds | ||
| if p.Spec.Lifecycle.DeletionGracePeriodSeconds != nil { |
Member
There was a problem hiding this comment.
This is for backward compatibility.
| InterStepBuffer *InterStepBuffer `json:"interStepBuffer,omitempty" protobuf:"bytes,9,opt,name=interStepBuffer"` | ||
| // ExactlyOnce is the exactly-once settings for the pipeline. | ||
| // +optional | ||
| ExactlyOnce *ExactlyOnce `json:"exactlyOnce,omitempty" protobuf:"bytes,10,opt,name=exactlyOnce"` |
Member
There was a problem hiding this comment.
Instead of calling it exactlyOnce, use deliverySemantics or delivery, and specify which one is used.
delivery:
exactlyOnce:
xxx: xx
atLeastOnce: {}| Enabled bool `json:"enabled,omitempty" protobuf:"bytes,1,opt,name=enabled"` | ||
| // ConsistentAck enables consistent acknowledgement of offsets to ISB throughout the pipeline. | ||
| // +kubebuilder:default=true | ||
| ConsistentAck bool `json:"consistentAck,omitempty" protobuf:"bytes,2,opt,name=consistentAck"` |
Member
There was a problem hiding this comment.
Use something with default value as false.
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.