Repository navigation
panel: include today's bytes in the ALL-TIME display - #17
Open
salmun-nister wants to merge 1 commit into
Open
salmun-nister wants to merge 1 commit into
salmun-nister wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16
Display-side fix for the static
ALL-TIMErow (option 2 in the issue): the daemon keepsallTimeas completed days only, so the panel adds today's bytes before formatting.Model.js- null-safe helper next tofmtGB:Panel.qml- the usage row:Testing
14.0 GB)0.0 GB—(null, not0.0 GB)Layout is unchanged - the string keeps the same shape and still formats through
fmtGB.Scope
Model.jsandPanel.qmlonly. No Go changes, sobackend/bin/starlinkdis untouched and the release gate's byte-identical check is unaffected. The rows this touches are separate from the ones in the power-block and 24 h-chart PRs, so it applies independently.Known trade-off
status.jsonstill reports the rolled figure (usage.allTime*), so the panel and the file disagree by one day's bytes. Moving the sum into the status builders is the follow-up described in the issue.