Repository navigation
fix: hide the power block when every sample is 0 W - #14
Open
salmun-nister wants to merge 1 commit into
Open
salmun-nister wants to merge 1 commit into
salmun-nister wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10
Change
Panel.qml- require a positive sample instead of mere presence. A live idle draw is tens of watts, so this cannot hide a dish that does measure:readonly property bool hasPower: { var p = h ? h.powerW : [] - for (var i = 0; i < p.length; i++) if (p[i] !== null && p[i] !== undefined) return true + for (var i = 0; i < p.length; i++) if (p[i] > 0) return true return false }Both existing consumers follow the flag, so no layout surgery:
visible: root.hasPoweron the section, and the adjacent chart's width (parent.widthwhen hidden, half when shown).Model.js- keep the bar tooltip consistent:README.md- one line under Requirements, where dish-capability notes belong:Testing
hist.jsonnot yet readpowerWabsent fromstatus.jsonScope
Display only;
backend/bin/starlinkduntouched. Independent of the other open PRs.