feat: add externalFileLinks to Issue entity - #180
Open
katayama8000 wants to merge 1 commit into
Open
Conversation
The Get Issue API response includes an `externalFileLinks` array (Scala: `IssueJson.sharedExternalFileLinks`), but the `Entity.Issue.Issue` type was missing it, so consumers had to cast to reach the field. Verified against a Backlog space that `GET /api/v2/issues/:issueIdOrKey` returns `externalFileLinks` on every issue (empty array when no links). `createdUser` / `updatedUser` are optional because they are `Option[User]` on the server side. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/v2/issues/:issueIdOrKeyのレスポンスにはexternalFileLinks（サーバ側IssueJson.sharedExternalFileLinks）が含まれていますが、Entity.Issue.Issueにこのフィールドが無く、利用側でキャストが必要でした。型を追加します。Changes
Entity.Issue.IssueにexternalFileLinks: ExternalFileLink[]を追加Entity.Issue.ExternalFileLinkを追加（id/serviceType/name/url/createdUser/created/updatedUser/updated）createdUser/updatedUserはサーバ側がOption[User]のため optionalexternalFileLinksが含まれることを確認するテストを追加Verification
実際の Backlog スペースに対して
GET /api/v2/issues/:issueIdOrKeyを叩き、リンクが無い課題でもexternalFileLinks: []が常に返ることを確認しました。npm run typecheck/npm test/npm run lint/npm run fmt:checkいずれもパスしています。🤖 Generated with Claude Code