fix(runner/traces): return empty result (no error) when ClickHouse is off - #531
Open
mayankpande88 wants to merge 3 commits into
Open
fix(runner/traces): return empty result (no error) when ClickHouse is off#531mayankpande88 wants to merge 3 commits into
mayankpande88 wants to merge 3 commits into
Conversation
… off api_traces_enricher_v2 set error="clickhouse: not configured" when the agent has no ClickHouse client. The backend traces parser treats that as a hard error and surfaces it to the user, even though "ClickHouse not configured" just means this cluster has no OTel trace store. Return the successful, empty traces payload with no `error` key so the parser renders the normal "no traces" empty state, matching the legacy get_application_traces behavior when the trace store is absent. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L2HAXQH1gEtX7h4sUJsi9j
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the API traces enricher to return an empty payload without an error key when ClickHouse is not configured, preventing a hard error from being surfaced to the user. The corresponding test case has been updated to verify that the error key is absent under these conditions. There are no review comments to assess, and I have no additional feedback to provide.
blue4209211
previously approved these changes
Jul 15, 2026
Contributor
|
📦 Image Tags Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
api_traces_enricher_v2 set error="clickhouse: not configured" when the
agent has no ClickHouse client. The backend traces parser treats that as
a hard error and surfaces it to the user, even though "ClickHouse not
configured" just means this cluster has no OTel trace store.
Return the successful, empty traces payload with no
errorkey so theparser renders the normal "no traces" empty state, matching the legacy
get_application_traces behavior when the trace store is absent.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01L2HAXQH1gEtX7h4sUJsi9j