Repository navigation
fix: gate the SIGTERM test to unix and mention shutdown in the quiet docs - #218
Merged
Merged
Conversation
…docs The quiet-mode test stops the server with `kill -TERM`, which Windows doesn't have, and off unix the server only listens for Ctrl+C. The README, the HTTP server doc and the changelog also said `--log quiet` covered startup messages, when it covers the shutdown line too.
Contributor
Criterion Benchmark ResultsBaseline is the per-benchmark median of the last 5 stored runs, so one unusually fast or slow runner cannot skew the comparison. The range column is the spread across those runs.
Runs in the baseline
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Two loose ends from #216. The quiet-mode test stops the server with
kill -TERM, so it's now gated to unix along with its helper: Windows has nokill, and the server only listens for Ctrl+C there. CI didn't notice becausethe Windows job runs
--libonly.The README,
docs/http-server.mdand the changelog entry said--log quietsuppressed startup messages. It covers the shutdown line as well, which is
what
--helpalready says.Checklist
Tests added or updated
cargo fmt --checkandcargo clippy -- -D warningspass locallyCHANGELOG.mdupdated if this is a user-visible changeLinked issue, discussion, or a short note explaining the motivation
I agree my contribution is licensed under the project's terms
(MIT License and Apache License, Version 2.0)
DynamoDB compatibility noteN/A: nothing here changes an observableDynamoDB behaviour.