Dependency updates - #25
Open
wneirynck wants to merge 1 commit into
Open
Conversation
Martian renamed encode-body to encode-request
|
The commit that broke backwards compatibility is oliyh/martian@6b46f60, first released as 0.1.32. |
|
In this PR you're using martian 0.1.32. Latest is 0.2.2, with breaking changes in 0.2.0 (https://github.com/oliyh/martian/releases/tag/0.2.0). Do you happen to know, with your PR applied, does k8s-api also work with the latter? |
|
@RafaeLeal, you appear to have been maintaining this library recently. Could you please take a look at this PR? It would unblock an update of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Martian renamed encode-body to encode-request and did not provide a backwards-compatible def. When including this lib in another project that uses a newer version of martian, things break. So hence this PR, which also does other dependency updates.