Skip to content

Jason's Review #19

Closed
#20
Closed
Jason's Review#19
#20

Description

@jdesrosiers
jdesrosiers
opened on Mar 16, 2026

Great job. I really appreciate that you wrote tests. The code is clean and well designed. There was just one thing I found that didn't work as expected. Local references don't work. Example:

{
  "foo": { "$ref": "#/a" },
  "a": 42
}

Activity

  1. ntoulasm
    added 2 commits that reference this issue on Mar 16, 2026

    fix(definition): handle local references (#19)

    42cb1a9

    fix: local references (#20)

    d208e19
  2. ntoulasm
    closed this as completedin #20on Mar 16, 2026

  3. ntoulasm commented on Mar 16, 2026

    @ntoulasm
    ntoulasm
    on Mar 16, 2026
    Owner

    Hi @jdesrosiers, I merged this PR, which adds a unit test to reproduce the case and fixes the local reference resolution. I really appreciate you taking the time to review and provide feedback! Have a nice day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions