Fix: Issue #33 setuptools is blocking the build with Python 3.12.3 - #36
Open
HarryKDeer wants to merge 1 commit into
Open
HarryKDeer wants to merge 1 commit into
HarryKDeer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the flat nature of the python directory, setuptools is not sure which files it should include. The reason why it appears to be a Python version issue is because of a setuptool update that went from guessing what should be included to failing a build for not explicitly stating what files are part of the setup package. As such, the fix is to define which files are part of the project (nsb_client) in pyproject.toml .
It should also be noted that there is another problem that the proto directory is a sibling directory to python, which would theoretically cause pip install issues because it wouldn't know to include proto. However, that is out of scope of the current issue, so this pull request only addresses the issue directly to leave room for discussion on how to proceed