Fix to undefined fraction denominator: Improved testing and better edge case handling - #6
Open
undermark5 wants to merge 10 commits into
Open
Fix to undefined fraction denominator: Improved testing and better edge case handling#6undermark5 wants to merge 10 commits into
undermark5 wants to merge 10 commits into
Conversation
… convertFromFraction, e.g. 1 2 lb chicken.
nsafai
reviewed
Mar 9, 2021
nsafai
left a comment
nsafai
left a comment
Owner
There was a problem hiding this comment.
Hey @undermark5 thanks for raising the PR. I do have some concerns with making this change because it can limit usability of the combine() feature and the future possibility of being able to convert units. Would love to get your thoughts
…dient as suggested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a combination of #3 plus the changes that I reference in my comment.
The biggest changes are an increase in the number of test cases (I'm not sure if they are in the proper place code wise or implemented properly) and the ability to handle more complex inputs including fractions (e.g.
"1-2 1/2 14.5 oz can tomato paste"->{quantity: '1-2.5', unit: '14.5 ounce', ingredient: 'can tomato paste', minQty: '1', maxQty: '2.5'})The multiplication is definitely an option, and maybe that could be a configuration option (or optional parameter), but I feel like people have an easier time doing multiplication than division.