Repository navigation
Bosch-A longitudinal: Testing's actuator modules on Bosch-A cars - #4
Merged
Merged
Conversation
…M-Testing Moves the Bosch-A decoding into a new bosch_a_radar.py (BoschARadar), copied from Biscuit-Labs Honda-PTM-Testing. RadarInterface(CP, CP_SP) now delegates the Bosch-A path to it and keeps only the Nidec path and nrdr's selection (DBC name plus radarUnavailable). The old inline Bosch-A code is deleted. point_statuses and a settable v_ego are exposed on the wrapper. Behavior now matches Testing: per-car ROM range offset, U11 at 1/72 m/s, 14.35 Hz, life-counter saturation, rail bounds, coast bounds including reversing coast, re-anchor/innovation, vrel-rate check, raw U11 0 = unmeasured. Testing's former toggles are hard-coded to its current defaults; no Params reads, no DBC changes. Tests: ported Testing's decoder tests (139) and radar-interface tests (the portable ones, 14 incl. parametrized); nrdr's 82 tests kept with expectations updated where Testing intentionally changed them (1/72 U11, 14.35 Hz, -346/128 offset, stale velocity no longer deletes the point). Evidence is static tests only; nothing here is road- or replay-validated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…A cars Ports bosch_longitudinal (BoschABrakeEdge), brake_onset, bosch_low_speed_brake and bosch_gas_learner from Biscuit-Labs Honda-PTM-Testing. On qualifying Bosch-A cars they replace nrdr's gas/wind factors and Bosch extra-brake controller. The Civic gas learner (HONDA_CIVIC_BOSCH only, as on Testing) also replaces MVL's learner when MVL is on. The stop counter on this path follows Testing (stopping state alone). Static evidence only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Reconciled the two repositories: opendbc's PR #2's Civic Bosch/Insight 3840 torque limits remain present. The older radar PR #1 is already ported and superseded. This reconciliation does not add replay/road-validation evidence or deploy anything to a vehicle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3 (the Bosch-A parser port). Review only the top commit, 427f198.
This brings Testing's Bosch-A actuator code from Biscuit-Labs/openpilot Honda-PTM-Testing into nrdr. On qualifying Bosch-A cars it replaces nrdr's gas and wind factors and its Bosch extra-brake controller. It is always on, with no toggles. Other cars are unchanged.
Ported from Testing:
bosch_longitudinal.py(includingBoschABrakeEdge),brake_onset.py,bosch_low_speed_brake.pyandbosch_gas_learner.py.brake_onset,bosch_low_speed_brakeandbosch_gas_learnerare byte-identical to Testing.bosch_longitudinalonly addsstar7_paramsandupdate_mvl_gas. No number or logic from Testing changed.When it runs
radarUnavailableFalse) and openpilot longitudinal. A Civic with its radar turned off keeps nrdr's path.BOSCH_ALT_RADAR) are not included, because nrdr's Bosch-A list leaves them out. Testing's list includes them. The 2019 Civic is not affected.Gas learner
CivicGasLearnerruns on HONDA_CIVIC_BOSCH only, as on Testing. Other Bosch-A cars get Testing's fixed gas and wind factors.mvl_longitudinal.py,update_mvl_gas). The car owner reported that MVL's learner over-revs on hills.Stopping
accel <= 0condition stays for every other Bosch car. That condition was there because nrdr's stopping ramp can still send positive acceleration. On this path the ramp is not used.test_bosch_stopping.pyhas updated Civic expectations that follow from this rule. The sent acceleration in the last case was recorded from a run.hondacan.create_acc_commandsgains an optionalbraking=Noneargument. Callers that leave it out get the old behaviour.Tests
test_bosch_longitudinal,test_brake_onset,test_bosch_low_speed_brakeandtest_bosch_gas_learnerfrom Testing.test_bosch_a_long_wiring, 11 tests covering the gate, the replaced controllers and the MVL learner swap.opendbc/car/honda/tests: 1267 passed, 43 failed, 3 skipped. The 43 failures also fail without this change: 42 intest_mvl_priority.pyand 1 intest_mvl_sync.py.🤖 Generated with Claude Code